feat(mempool): revert transactions after 3 failures#1832
Merged
Mirko-von-Leipzig merged 44 commits intonextfrom Mar 29, 2026
Merged
feat(mempool): revert transactions after 3 failures#1832Mirko-von-Leipzig merged 44 commits intonextfrom
Mirko-von-Leipzig merged 44 commits intonextfrom
Conversation
Mirko-von-Leipzig
added
the
no changelog
Mirko-von-Leipzig
force-pushed
the
mirko/mempool-tx-reverting
branch
from
0ded389 to
ccecfa5
Compare
sergerad
approved these changes
Mar 25, 2026
sergerad
reviewed
Mar 25, 2026
sergerad
reviewed
Mar 25, 2026
igamigo
approved these changes
Mar 25, 2026
Collaborator
igamigo
left a comment
igamigo
left a comment
There was a problem hiding this comment.
LGTM! Left a couple of minor comments
igamigo
reviewed
Mar 25, 2026
Mirko-von-Leipzig
force-pushed
the
mirko/mempool-tx-reverting
branch
from
7706fc9 to
f01d124
Compare
Mirko-von-Leipzig
force-pushed
the
mirko/mempool-tx-reverting
branch
from
f684e15 to
59877ef
Compare
bobbinth
reviewed
Mar 29, 2026
Contributor
bobbinth
left a comment
bobbinth
left a comment
There was a problem hiding this comment.
Looks good! Thank you! I know this has been merged already, but it may be good to do a follow-up PR which clarifies/updates some doc comments.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR changes the mempool behaviour when rolling back blocks and batches. Transactions are now reverted once they have participated in more than three failed batches and blocks.
The current behaviour is that transactions are never reverted for batch failures, and always reverted for block failures.
The intention here is to weed out transactions which cause these failures e.g. due to a bug in the prover/mempool/node. The new implementation is a bit more forgiving and gives innocent bystander transactions a couple of chances to avoid the buggy one.
The limit of three is arbitrary, but I also don't see a good reason to make this more configurable. Fight me :)
This PR builds on the mempool refactor in #1820.
Closes #594