fix: Update SyncChainMmr endpoint upper bound logic#1860
Open
fix: Update SyncChainMmr endpoint upper bound logic#1860
Conversation
sergerad
added
the
no changelog
Mirko-von-Leipzig
approved these changes
Mar 30, 2026
Comment on lines
+504
to
+511
| oneof upper_bound { | ||
| // Sync up to this specific block number (inclusive), clamped to the effective tip. | ||
| fixed32 block_num = 3; | ||
| // Sync up to the latest committed block (chain tip). | ||
| bool last_committed = 4; | ||
| // Sync up to the latest proven block. | ||
| bool last_proven = 5; | ||
| } |
Collaborator
There was a problem hiding this comment.
Is this the recommended way to emulate sum types in protobuf?
Haven't seen bool used as a placeholder before - what happens if they're manually set to false?
Collaborator
Author
There was a problem hiding this comment.
The value of the boolean is ignored
match value {
UpperBound::BlockNum(block_num) => Ok(Self::BlockNumber(block_num.into())),
UpperBound::CommittedChainTip(_) => Ok(Self::CommittedChainTip),
UpperBound::ProvenChainTip(_) => Ok(Self::ProvenChainTip),
}
Collaborator
There was a problem hiding this comment.
I know. But since these are numbered fields, and protobuf default inits fields at the receiver, what actually happens if I send last_proven = false -- does it not still get last_committed = false.
SantiagoPittella
approved these changes
Mar 30, 2026
Collaborator
SantiagoPittella
left a comment
SantiagoPittella
left a comment
There was a problem hiding this comment.
Looks good, agree w Mirko's comments.
bobbinth
approved these changes
Mar 30, 2026
Contributor
bobbinth
left a comment
bobbinth
left a comment
There was a problem hiding this comment.
Looks good! Thank you! I left one comment inline and agree with @Mirko-von-Leipzig's comments.
Mirko-von-Leipzig
approved these changes
Mar 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1842.