Skip to content

fix: fetch network accounts pagination#1869

Open
SantiagoPittella wants to merge 2 commits intonextfrom
santiagopittella-fix-ntx-builder-paginated-query
Open

fix: fetch network accounts pagination#1869
SantiagoPittella wants to merge 2 commits intonextfrom
santiagopittella-fix-ntx-builder-paginated-query

Conversation

@SantiagoPittella
Copy link
Copy Markdown
Collaborator

closes #1868

@SantiagoPittella SantiagoPittella added the no changelog This PR does not require an entry in the `CHANGELOG.md` file label Mar 31, 2026
@SantiagoPittella SantiagoPittella force-pushed the santiagopittella-fix-ntx-builder-paginated-query branch from 84828a5 to 8030090 Compare March 31, 2026 20:39
Copy link
Copy Markdown
Collaborator

@igamigo igamigo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I wonder if all of these minor details and inconsistencies are calling for building some of the functionality into a pagination helper structure or something similar.

Copy link
Copy Markdown
Contributor

@bobbinth bobbinth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you!

I agree with @igamigo that some kind of pagination helper would be useful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no changelog This PR does not require an entry in the `CHANGELOG.md` file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

NTX builder may be loading duplicate IDs

3 participants