Revisit CrossChainReceiverFactory to make it more composable#430
Draft
Revisit CrossChainReceiverFactory to make it more composable#430
CrossChainReceiverFactory to make it more composable#430Conversation
…d tokens to the multicall contract and want to get them out
e1Ru1o
reviewed
Dec 18, 2025
Comment on lines
+912
to
+920
| assembly ("memory-safe") { | ||
| mstore(callvalue(), 0x2e1a7d4d) // `IWrappedNative.withdraw.selector` | ||
| mstore(0x20, toUnwrap) | ||
|
|
||
| if iszero(call(gas(), wnative, callvalue(), 0x1c, 0x24, codesize(), callvalue())) { | ||
| // this should never happen | ||
| revert(codesize(), callvalue()) | ||
| } | ||
| } |
Contributor
There was a problem hiding this comment.
no if to avoid the unwrap if by some reason toUnwrap is zero?
…771-forwarding `MultiCall`) is implemented correctly
…trieve an alternative `MultiCall` address if it fails
…cting `CrossChainReceiverFactory`. Namely, it is a mandatory "argument"
…` in `getFromMulticall`
duncancmt
force-pushed
the
master
branch
6 times, most recently
from
b8e3001 to
af9b948
Compare
duncancmt
added
the
audit
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.