Quote the name of the maybe/2 type#10
Open
kivra-pergus wants to merge 86 commits into0xYUANTI:masterfrom
Open
Conversation
Add luhn implementation
Add s2_math with ceiling and floor functions.
Ifdef all tests
Add histogram for kivra metrics
* This will also enable warnings in Sentry
* feat: added support for OTP logger * fix: added missing include. * only include otp logger header if it is needed
* chore: create exception reports lazily * more verbose
Quotes definition and use of the maybe/2 type, also exports the type from s2_maybe because it was already used as if exported from there.
kivra-pergus
force-pushed
the
'maybe'_notmaybe
branch
2 times, most recently
from
ebda949 to
de77ba6
Compare
Ci on github no longer worked.
kivra-pergus
force-pushed
the
'maybe'_notmaybe
branch
from
411fde8 to
0af3e44
Compare
kivra-pergus
force-pushed
the
'maybe'_notmaybe
branch
from
9888563 to
961eb41
Compare
kivra-pergus
force-pushed
the
'maybe'_notmaybe
branch
from
5429dd5 to
3408672
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
18 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In OTP 27 maybe will become a keyword so to support using stdlib2 in OTP27 we need to quote usages of maybe as an atom.