rewards: depositVaultShares pre-NAV; add tests#32
Draft
Conversation
Collaborator
Author
youngkidwarrior
force-pushed
the
rewards_depositvaultshares_pre-nav_add_tests
branch
from
0e3452d to
0aa7762
Compare
Why: Align depositVaultShares with ERC4626 preview semantics by minting shares using pre-ingestion NAV (snapshot totalAssets/totalSupply) so previewDeposit matches runtime behavior. Adds domain tests for SendEarn-wrapper behavior (routing, gating, NAV invariants, and depositVaultShares reverts). Gates CFA/integration suites until v2.1. Test plan: - npx hardhat test - Expect: ERC4626-only suite green; new NAV test passes; CFA/integration suites are pending unless RUN_CFA/RUN_INTEGRATION are set.
youngkidwarrior
force-pushed
the
rewards_depositvaultshares_pre-nav_add_tests
branch
from
0aa7762 to
4846449
Compare
youngkidwarrior
changed the base branch from
graphite-base/32
to
docs_adopt_nav-based_accounting_and_dual_deposit_modes_clarify_single-vault_withdraw_redeem
This was referenced Sep 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why:
Align depositVaultShares with ERC4626 preview semantics by minting
shares using pre-ingestion NAV (snapshot totalAssets/totalSupply) so
previewDeposit matches runtime behavior. Adds domain tests for
SendEarn-wrapper behavior (routing, gating, NAV invariants, and
depositVaultShares reverts). Gates CFA/integration suites until v2.1.
Test plan:
suites are pending unless RUN_CFA/RUN_INTEGRATION are set.