Refactor options pages markup to follow WordPress standards#193
Open
claytoncollie wants to merge 3 commits intodevelopfrom
Open
Refactor options pages markup to follow WordPress standards#193claytoncollie wants to merge 3 commits intodevelopfrom
claytoncollie wants to merge 3 commits intodevelopfrom
Conversation
Contributor
|
@claytoncollie thank you for putting this together! Can we also do this for
|
Contributor
Author
|
@darylldoyle Refactored Comments and SSO on single and multisite |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

This PR addresses #41 to fix the alignment and accessibility of checkbox and radio fields in the wp-admin settings pages. The markup has been updated to match WordPress Core patterns for form controls. This is a refactor, not a functionality change.
Changes made:
Checkbox fields (
Gutenberg.php,PostPasswords.php):label_forargument fromadd_settings_field()since checkboxes shouldn't have the row label linked to them<label>elements with description text inside, matching Core's checkbox patternRadio fields (
Passwords.php,Monitor.php):label_forargument fromadd_settings_field()for radio groups<fieldset>wrapper with<legend class="screen-reader-text">for accessibility<label>elementBenefits:
Closes #41
How to test the Change
/wp-admin/options-writing.php):/wp-admin/options-general.php):/wp-admin/network/settings.php):Changelog Entry
Changed - Updated admin markup for checkbox and radio fields to match WordPress Core accessibility patterns
Credits
Props @claytoncollie
Checklist: