Fix: pass eslint flags to linting action to ignore dist/** & use correct config file#202
Open
fabiankaegy wants to merge 1 commit intodevelopfrom
Open
Fix: pass eslint flags to linting action to ignore dist/** & use correct config file#202fabiankaegy wants to merge 1 commit intodevelopfrom
dist/** & use correct config file#202fabiankaegy wants to merge 1 commit intodevelopfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This pull request updates the ESLint GitHub Actions workflow to explicitly specify the ESLint configuration file and exclude the dist directory from linting. The change addresses issue #201 by preventing the linter from checking compiled/built JavaScript files.
- Adds explicit
eslint_flagsparameter to the reviewdog ESLint action - Configures ESLint to use
.eslintrc.jsas the configuration file - Ignores the
dist/**directory pattern during linting
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
|
@fabiankaegy I understand passing the flag to make sure the correct config is used but shouldn't the dist ignore be in the eslint.js file so that it is also ignored when you use the pre-commit hooks or the npm commands manually? |
Contributor
|
@fabiankaegy just following up to ensure you seen Clayton's comment above |
Contributor
|
@fabiankaegy What do you think about #218 ?? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request makes a minor update to the ESLint workflow configuration. The change ensures that the linter uses the correct configuration file and ignores the
distdirectory during linting.Closes #201