Add --include_files --include_db flags#34
Conversation
Include the ` --include_files --include_db` flags
Remove the value for the `--overwrite_local_copy` flag
|
This is blocking the WPAcceptance test on CI because |
|
@tlovett1 Please consider merging this PR and update the wpacceptance docker image so we can continue running WPA for 10up's open-source plugins. Currently, WPA tests of plugins using snapshots are failing because the |
|
Applying this PR, @thrijith found another issue while working on the A11y Checkup plugin, which I can reproduce on my end. Warning: rmdir(/root/.wpsnapshots/a3f2959614a18989ea365da4d86945f1/): Device or resource busy in /root/.composer/vendor/10up/wpsnapshots/src/utils.php on line 359SSH into the container, I got the same error trying to delete the folder manually: root@d4165de11326:~/.wpsnapshots# rm -rf a3f2959614a18989ea365da4d86945f1/
rm: cannot remove 'a3f2959614a18989ea365da4d86945f1/': Device or resource busyThis issue only happens inside wpa container, I can pull with IMO, the best way to solve this issue is allowing bypass |
|
I created a PR to fix the overwriting local snapshot issue: 10up/wpsnapshots#86. @felipeelia After the 86 is merged, can you please revert the change in fdbdf8d? |
Include the
--include_files --include_dbflags in thewpsnapshots pullcall.Description of the Change
Without those, the command will wait for a user input that will never come.