Conversation
| } | ||
|
|
||
| class Rectangle extends Shape { | ||
| constructor(length, width) { |
There was a problem hiding this comment.
Since this constructor is exactly identical as Shape's constructor, it is not necessary. It will automatically take everything inside the Shape class.
|
|
||
| class Triangle extends Shape { | ||
| constructor(length, width) { | ||
| super(length, width / 2); |
There was a problem hiding this comment.
🤔 , is it necessary to divide the width by 2? If I gave you this triangle and told you the width was 10cm and the height was 6cm. Would you expect the width to be 5?
| } | ||
| class Circle extends Shape { | ||
| constructor(radius) { | ||
| super(radius * radius, Math.PI); |
There was a problem hiding this comment.
This is actually an interesting one! Since a circle doesn't really have a length or height, but what you did is clever since it would still leverage the area function 👍. One thing to note is that it's not always necessary to call super.
| } | ||
| class Cube extends Shape { | ||
| constructor(length, width, height) { | ||
| super(length * width, height); |
There was a problem hiding this comment.
This one might actually be better as something like this. You would also need to override the area function meaning you need to create a new one in this class.
constructor(length, width, height) {
this.height = height;
super(length, width);
}
2 participants
completed
@griselleong
@rickyc