Skip to content

Fix 48 mimification - Features master#38

Merged
igor024 merged 2 commits intomasterfrom
features-master
Mar 28, 2026
Merged

Fix 48 mimification - Features master#38
igor024 merged 2 commits intomasterfrom
features-master

Conversation

@igor024
Copy link
Copy Markdown
Collaborator

@igor024 igor024 commented Mar 28, 2026

Summary by CodeRabbit

  • Bug Fixes
    • Enhanced data serialization handling in release builds to ensure all API responses are properly preserved during app compilation.

@igor024 igor024 merged commit a90b5e9 into master Mar 28, 2026
1 check failed
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Mar 28, 2026

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 6ec26c7b-1d49-4f5b-8f29-da8711561c88

📥 Commits

Reviewing files that changed from the base of the PR and between c86f97a and 64797a8.

📒 Files selected for processing (1)
  • app/proguard-rules.pro

Walkthrough

ProGuard/R8 keep rules were modified to consolidate API class preservation. A specific keep rule for ApiResponse class was removed, and the broader package-level rule was expanded from data.api.model.** to data.api.** to cover all classes under the API package.

Changes

Cohort / File(s) Summary
ProGuard Configuration
app/proguard-rules.pro
Removed explicit keep rule for ApiResponse class; expanded existing keep rule from data.api.model.** to data.api.** to preserve all API-related classes during code obfuscation.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 A ProGuard rule hops into place,
Classes safe in their API space,
Obfuscation won't mangle our way,
All kept intact, hip-hip-hooray!

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch features-master

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant