Skip to content

Features master#39

Merged
SuperMeerkat345 merged 7 commits intomasterfrom
features-master
Mar 29, 2026
Merged

Features master#39
SuperMeerkat345 merged 7 commits intomasterfrom
features-master

Conversation

@SuperMeerkat345
Copy link
Copy Markdown
Collaborator

@SuperMeerkat345 SuperMeerkat345 commented Mar 29, 2026

Merge features-master into master for version 1.0.1.
The CI/CD workflow should begin after the pull req.

Summary by CodeRabbit

  • New Features

    • Improved task sorting and organization in the tasks view for better workflow management.
  • Bug Fixes

    • Fixed task data mapping to ensure accurate information display.
    • Refined postgame button conditions for proper state management.
  • Chores

    • Version bumped to 1.0.1.
    • Updated testing dependencies.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Mar 29, 2026

Caution

Review failed

Pull request was closed or merged during review

Walkthrough

This PR bumps the app version to 1.0.1, removes synchronization guards and state tracking via isReady from repositories, simplifies task sorting in the UI, fixes a task mapping parameter, adds debug logging, updates dependencies, and refines the postgame button condition.

Changes

Cohort / File(s) Summary
Build & Dependencies
app/build.gradle.kts, gradle/libs.versions.toml
Version bump from 1.0.0 to 1.0.1 and addition of JUnit 5 (5.14.0) test dependency.
Repository State Cleanup
app/src/main/java/com/team695/scoutifyapp/data/repository/GameDetailRepository.kt, app/src/main/java/com/team695/scoutifyapp/data/repository/MatchSchedule.kt
Removed isReady state updates and pulledConstants guard logic from GameDetailRepository.fetch(). Added explicit CancellationException handling and refined error propagation.
Task Repository & Model
app/src/main/java/com/team695/scoutifyapp/data/api/model/Task.kt, app/src/main/java/com/team695/scoutifyapp/data/repository/TaskRepository.kt
Fixed Task.createTaskFromDb() to use correct time_ field parameter and added debug print statement for task entities.
Network & Sync Logic
app/src/main/java/com/team695/scoutifyapp/data/api/NetworkMonitor.kt, app/src/main/java/com/team695/scoutifyapp/data/repository/TeamNameRepository.kt
Removed isReady synchronization wait after fetch and added debug output in NetworkMonitor. Refactored TeamNameRepository.fetch() to explicitly return Result from withContext lambda.
ViewModel State
app/src/main/java/com/team695/scoutifyapp/ui/viewModels/HomeViewModel.kt, app/src/main/java/com/team695/scoutifyapp/ui/viewModels/CommentViewModel.kt
Removed public isReady: StateFlow<Boolean> property from HomeViewModel. Cleaned up inline comment in CommentViewModel.onMatchSelected().
UI Logic Refinement
app/src/main/java/com/team695/scoutifyapp/ui/screens/home/TasksCard.kt, app/src/main/java/com/team695/scoutifyapp/ui/screens/data/EndgameDetails.kt
Implemented sophisticated task sorting with complete/incomplete splits and reordering logic based on latest complete task time. Tightened postgame button condition to require teleopCachedMilliseconds == 0.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

Possibly related PRs

  • Features master #12: Modifies HomeViewModel and TasksCard with overlapping state usage and UI changes.
  • Features master #18: Updates Task mapping and TaskRepository logic with direct code-level overlap on task entity handling.
  • Features master #25: Alters GameDetailRepository.isReady and pulledConstants features alongside related synchronization code.

Suggested labels

enhancement

Poem

🐰 Ready, set, refactor!
No more waiting for the state,
Tasks now sorted, clean and straight,
Version bumps and bugs abate,
Hopping forward—test intake! 🥬

🚥 Pre-merge checks | ✅ 1 | ❌ 2

❌ Failed checks (1 warning, 1 inconclusive)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 20.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
Title check ❓ Inconclusive The title 'Features master' is vague and generic, failing to convey meaningful information about the changeset. It does not describe the actual changes like version bump, bug fixes, or feature improvements. Revise the title to be more specific and descriptive, such as 'Bump version to 1.0.1 and fix coroutine cancellation errors' or similar, clearly indicating the primary changes.
✅ Passed checks (1 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch features-master

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai coderabbitai Bot added the enhancement New feature or request label Mar 29, 2026
@SuperMeerkat345 SuperMeerkat345 merged commit a6990b6 into master Mar 29, 2026
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants