Conversation
- Created FxLayer.perf.test.ts to benchmark the performance of the original FxLayer implementation. - Created FxLayerV2.perf.test.ts to compare the performance of FxLayerV2 against the original FxLayer. - Introduced fx-layer-bench-harness.ts to provide a reusable benchmarking harness for rendering layers with visual effects. - Implemented various benchmark scenarios to evaluate performance under different conditions, including explosion effects and rendering efficiency.
El-Magico777
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces performance benchmarking tests for both the original
FxLayerand the newFxLayerV2, and updates the game renderer to useFxLayerV2instead ofFxLayer. The main goal is to compare and validate the performance improvements brought byFxLayerV2and ensure consistent rendering behavior in the game client.Performance benchmarking and testing:
FxLayerV2.perf.test.tsto compare the performance ofFxLayer(V1) andFxLayerV2across multiple scenarios, printing side-by-side results for analysis.FxLayerinFxLayer.perf.test.tsusing a factory harness for consistent measurement and comparison.Renderer integration:
GameRenderer.tsto useFxLayerV2(aliased asFxLayer) instead of the originalFxLayer, ensuring the renderer utilizes the optimized implementation.