Add contact & policy pages and fix footer links#46
Add contact & policy pages and fix footer links#46mjfxjas wants to merge 1 commit into1instinct:@aaron.smulktis/developfrom
Conversation
aaronsmulktis
left a comment
There was a problem hiding this comment.
Most of these changes are great... few requests to revert some things, which you can easily do by running:
git checkout ./path/to/file/to/revert.tsx
I didn't test this branch locally, didn't feel like cloning your repo... I'll most likely just approve & merge after you address these changes
Thank you!!
There was a problem hiding this comment.
I would remove these changes.. the loading component works again... you just need to run:
git pull upstream @aaron.smulktis/develop
There was a problem hiding this comment.
I would remove these changes too.. they seem good (in theory)... check if the window object exists, but its currently working without all these changes... we just need to "lazy load" this everywhere (see useCart, useProducts, or any other hook in that folder)
There was a problem hiding this comment.
I don't think this is necessary either?
There was a problem hiding this comment.
You can prob remove this too
There was a problem hiding this comment.
I think the app may break using any newer version than 18... but we can try this
|
You can resolve these merge conflicts by doing something similar to what I was doing today... While on your branch run:
|
1: Adds pages:
/contact, /accessibility, /ca-privacy-right, /prop65, /rewards, /returns
2: Updates footer links to use Next.js and point to the new routes
3: Minor cleanup only; no unrelated refactors