Skip to content

Disable SESSION_COOKIE_DOMAIN in local environment #319

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
niccolomineo wants to merge 1 commit into
base: main
Choose a base branch
from
+6 −3
Open

Disable SESSION_COOKIE_DOMAIN in local environment #319

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion {{cookiecutter.project_dirname}}/.env_template
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ DJANGO_DEBUG=True
DJANGO_DEFAULT_FROM_EMAIL=info@example.org
DJANGO_SECRET_KEY=__SECRETKEY__
DJANGO_SERVER_EMAIL=server@example.org
DJANGO_SESSION_COOKIE_DOMAIN=localhost
DJANGO_SUPERUSER_EMAIL=info@example.org
DJANGO_SUPERUSER_PASSWORD={{ cookiecutter.project_slug }}
DJANGO_SUPERUSER_USERNAME=${USER}
Expand Down
1 change: 0 additions & 1 deletion {{cookiecutter.project_dirname}}/docker-compose.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@ services:
- DJANGO_DEFAULT_FROM_EMAIL
- DJANGO_SECRET_KEY
- DJANGO_SERVER_EMAIL
- DJANGO_SESSION_COOKIE_DOMAIN
- DJANGO_SUPERUSER_EMAIL
- DJANGO_SUPERUSER_PASSWORD
- DJANGO_SUPERUSER_USERNAME
Expand Down
7 changes: 6 additions & 1 deletion {{cookiecutter.project_dirname}}/{{cookiecutter.django_settings_dirname}}/settings.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,7 +180,7 @@ class ProjectDefault(Configuration):
# Session auth
# https://docs.djangoproject.com/en/stable/ref/settings/#sessions

SESSION_COOKIE_DOMAIN = values.Value()
SESSION_COOKIE_DOMAIN = None

SESSION_COOKIE_SECURE = True

Expand Down Expand Up @@ -392,6 +392,11 @@ def DATABASES(self): # pragma: no cover

X_FRAME_OPTIONS = "DENY"

# Session auth
# https://docs.djangoproject.com/en/stable/ref/settings/#sessions

SESSION_COOKIE_DOMAIN = values.Value()

# Persistent connections
# https://docs.djangoproject.com/en/stable/ref/databases/#general-notes

Expand Down