Add terraform fmt and validate in pre-commit #48
+488
−515
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trottomv
requested review from
Arussil,
Mitchina,
daniele-20tab,
filippo-20tab,
flavio-bernasconi,
niccolomineo and
pauloxnet
ipython to 8.12.0
trottomv
force-pushed
the
feature/terraform-pre-commit
branch
from
6e31d52 to
fc14cbc
Compare
trottomv
force-pushed
the
main
branch
2 times, most recently
from
458d760 to
976536e
Compare
Member
|
Does this implementation require the user to have Terraform installed? If so, I disagree with adding an additional requirement; a basic developer is not obligated to install it. |
| @@ -1,3 +1,3 @@ | |||
| -r test.in | |||
| ipython~=8.8.0 | |||
| ipython~=8.12.0 | |||
Member
There was a problem hiding this comment.
Suggested change
| ipython~=8.12.0 | |
| ipython~=8.20.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.