🩹 fix: login jwtathentificationfilter 개선#40
Merged
zzangkkmin merged 4 commits intodevfrom Feb 24, 2025
Hidden character warning
The head ref may contain hidden characters: "enhancement/35-enhancement-login-jwtathentificationfilter-\uac1c\uc120"
Merged
Conversation
Bulgogi-Pizza
requested review from
Bulgogi-Pizza,
chokyuseong00,
mummumm and
sohyun119
Bulgogi-Pizza
approved these changes
Feb 24, 2025
Contributor
Bulgogi-Pizza
left a comment
Bulgogi-Pizza
left a comment
There was a problem hiding this comment.
LGTM
코드가 사라짐에 애도를 표합니다.
고생하셨습니다.
ㅠㅠ
chokyuseong00
approved these changes
Feb 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
✨ 변경 타입
✅ 체크리스트
🚀 변경 내용
as-is
jwt관련 코드들 흩어짐, AthentifiicatiionFilter로 로그인 중
to-be
jwt관련 코드들을 user domain의 jwt 폴더로 관리, AthentifiicatiionFilter로 로그인 검증과정 추가, 기존 user controller/service 로그인 삭제
💡 추가 설명