Skip to content

🩹 fix [#41] : user νšŒμ›κ°€μž… validation 적용#42

Merged
mummumm merged 1 commit intodevfrom
enhancement/41-username-password-email-validation
Feb 24, 2025
Merged

🩹 fix [#41] : user νšŒμ›κ°€μž… validation 적용#42
mummumm merged 1 commit intodevfrom
enhancement/41-username-password-email-validation

Conversation

@mummumm
Copy link
Contributor

@mummumm mummumm commented Feb 24, 2025

✨ λ³€κ²½ νƒ€μž…

  • μ‹ κ·œ κΈ°λŠ₯ μΆ”κ°€/μˆ˜μ •
  • 버그 μˆ˜μ •
  • λ¦¬νŒ©ν† λ§
  • μ„€μ •
  • λΉ„κΈ°λŠ₯ (주석 λ“± κΈ°λŠ₯에 영ν–₯을 μ£Όμ§€ μ•ŠμŒ)

βœ… 체크리슀트

  • μ½”λ“œ μž‘μ„± κ°€μ΄λ“œλΌμΈμ„ μ€€μˆ˜ν–ˆλŠ”κ°€?
  • λ³€κ²½ 사항에 λŒ€ν•œ ν…ŒμŠ€νŠΈλ₯Ό μ™„λ£Œν–ˆλŠ”κ°€?
  • λ¬Έμ„œ 변경이 ν•„μš”ν•œ 경우, ν•΄λ‹Ή λ‚΄μš©μ„ λ°˜μ˜ν–ˆλŠ”κ°€?

πŸš€ λ³€κ²½ λ‚΄μš©

  • as-is

    • νšŒμ›κ°€μž… μ‹œ μž…λ ₯데이터 νŒ¨ν„΄κ³Ό 상관없이 λͺ¨λ“  데이터가 λ°μ΄ν„°λ² μ΄μŠ€μ— μ €μž₯됌
  • to-be

    • μ§€μ •λœ νŒ¨ν„΄μ— λΆ€ν•©ν•˜λŠ” λ°μ΄ν„°λ§Œ λ°μ΄ν„°λ² μ΄μŠ€μ— μ €μž₯됌

πŸ’‘ μΆ”κ°€ μ„€λͺ…

πŸ“š μ°Έκ³  자료 (선택 사항)

- UserController, UserDto 클래슀 μˆ˜μ •
@mummumm mummumm added the πŸ”¨ Refactor μ½”λ“œ λ¦¬νŒ©ν† λ§ label Feb 24, 2025
@mummumm mummumm self-assigned this Feb 24, 2025
@mummumm mummumm linked an issue Feb 24, 2025 that may be closed by this pull request
@mummumm mummumm requested a review from zzangkkmin February 24, 2025 07:53
Copy link
Contributor

@zzangkkmin zzangkkmin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ν™•μΈν•˜μ˜€μŠ΅λ‹ˆλ‹€.

Copy link
Contributor

@Bulgogi-Pizza Bulgogi-Pizza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
κ³ μƒν•˜μ…¨μŠ΅λ‹ˆλ‹€!

Copy link
Member

@sohyun119 sohyun119 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

μ§±~!

@mummumm mummumm merged commit 367d4d3 into dev Feb 24, 2025
@chokyuseong00 chokyuseong00 deleted the enhancement/41-username-password-email-validation branch March 14, 2025 03:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

πŸ”¨ Refactor μ½”λ“œ λ¦¬νŒ©ν† λ§

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[enhancement] username, password, email νŒ¨ν„΄ μΆ”κ°€

5 participants