Added a numeric-up-down control. This works for maps and the tilesets…#3
Open
Added a numeric-up-down control. This works for maps and the tilesets…#3
Conversation
…. The utility doesn't draw map #13 to the screen but allows the user to select 13. Tileset 13 is drawn.
2Tie
reviewed
Jun 5, 2018
Owner
2Tie
left a comment
2Tie
left a comment
There was a problem hiding this comment.
looks good for the most part - if you're going to let the user select map 13 and not draw it, there should be some indication of this, so they don't think it's possibly a duplicate map like 218 is.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…. The utility doesn't draw map #13 to the screen but allows the user to select 13. Tileset 13 is drawn.