Skip to content

fix: re-declare ARG in each Dockerfile stage#19

Merged
GraysonCAdams merged 1 commit intomainfrom
fix/dockerfile-arg-scoping
Mar 1, 2026
Merged

fix: re-declare ARG in each Dockerfile stage#19
GraysonCAdams merged 1 commit intomainfrom
fix/dockerfile-arg-scoping

Conversation

@GraysonCAdams
Copy link
Copy Markdown
Collaborator

Summary

  • Re-declares ARG APP_VERSION inside each build stage so the global ARG value is properly inherited
  • Without this, Docker emits UndefinedVar warnings and the variable resolves to empty string instead of the --build-arg value

Test plan

  • Built locally with docker build --build-arg APP_VERSION=1.1.0 -t scrolly:test . — no warnings
  • Container started, health check returns {"version":"1.1.0"} (confirming ARG propagated correctly)
  • All endpoints validated (join, auth, manifest, service worker, offline)

@GraysonCAdams GraysonCAdams merged commit 4ed132f into main Mar 1, 2026
13 checks passed
@GraysonCAdams GraysonCAdams deleted the fix/dockerfile-arg-scoping branch March 1, 2026 06:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant