fix: share auto-submit, favorites reel back-button & auto-scroll#48
Merged
GraysonCAdams merged 2 commits intomainfrom Mar 3, 2026
Merged
Conversation
- Auto-submit when URL is valid and platform is allowed (no tap needed) - Show "Adding to feed…" loading state while submitting - Show dedicated error state with "Try again" button on failure - Remove fromShortcut branch — auto-submit supersedes the shortcut flow - Fix .err CSS alias for error icon wrap styling
- Defer onReelPopState so SvelteKit updates page.state before we check it; prevents reel from closing when a sheet on top dismisses via back button - Disable autoScroll in favorites reel (was incorrectly inherited from prefs)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fromShortcutbranching logic since auto-submit supersedes it.onReelPopStatehandler by one tick so SvelteKit can updatepage.statebefore we inspect it. This prevents the reel from closing when a bottom sheet on top (comments, viewers, etc.) is dismissed via the back gesture.autoScrollwas being passed from user prefs into the favorites reel — hardcoded tofalsesince auto-advance doesn't make sense for a hand-curated list.Test plan