New popup styles#12
Open
chinaowl wants to merge 6 commits into350dotorg:gh-pagesfrom
thoughtworks:popup-styles
Open
New popup styles#12chinaowl wants to merge 6 commits into350dotorg:gh-pagesfrom thoughtworks:popup-styles
chinaowl wants to merge 6 commits into350dotorg:gh-pagesfrom
thoughtworks:popup-styles
Conversation
|
|
| @@ -0,0 +1,283 @@ | |||
| @charset "utf-8"; | |||
Contributor
Author
There was a problem hiding this comment.
This is a CSS file that Matthew gave us to use.
Contributor
Author
|
One important thing to note is that for the styles to work, I had to change the markup in the Google spreadsheet for the existing popups (local groups, power shifts, and fossil free groups). I tested it with the copy that I have: https://docs.google.com/spreadsheets/d/1FW0GW7YQjY_9_wVf1XGKkpqImaHGuGpIgOt13aCp1qY/edit?pref=2&pli=1#gid=2 But you will have to copy over the markup to the production Google sheet after this is merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @ejucovy,
These are the CSS changes for the new popup styles that Matthew wanted. I showed Matthew a bunch of screenshots, which he approved in Slack. (Is he on GitHub?)
A big thank you to @nliaoTW and @NataliePollard for contributing to this PR! 👏