Add webpack with single file loading#13
Open
chinaowl wants to merge 1 commit into350dotorg:gh-pagesfrom
thoughtworks:webpack
Open
Add webpack with single file loading#13chinaowl wants to merge 1 commit into350dotorg:gh-pagesfrom thoughtworks:webpack
chinaowl wants to merge 1 commit into350dotorg:gh-pagesfrom
thoughtworks:webpack
Conversation
Contributor
Author
|
Actually, we are almost done with migrating to npm, so maybe we can hold off on this one for now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi Ethan,
We are opening this PR to start a conversation about JS bundling (not necessary to merge right away). For this PR, we were able to bundle all of our source JS files. We'll attempt to bundle dependencies in our next hack night.
A few things...
@tainacaetano