Open
Conversation
✅ Deploy Preview for 3dstreet-core-builds ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Contributor
Author
|
It looks like Node v12 doesn't support "nullish coalescing operator (??)". I'll change it |
node v12 on server doesn't support (??) operator
Collaborator
we can upgrade node, i think 12 is pretty old now right? |
Collaborator
|
@Algorush is this ready for testing? |
Collaborator
|
a few questions @Algorush
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not done yet. I also need to make different speeds for different characters.
And there is one issue to fix. After switching the globalAnimation in the street component to true, the added characters stand with their arms outstretched to the sides in the Editor, but after switching to View everything is fine