Skip to content

fix: lowercase PLUGIN_NAME to match directory name on case-sensitive …#1

Open
PaoloC68 wants to merge 1 commit into3clyp50:mainfrom
PaoloC68:fix/plugin-name-case-sensitivity
Open

fix: lowercase PLUGIN_NAME to match directory name on case-sensitive …#1
PaoloC68 wants to merge 1 commit into3clyp50:mainfrom
PaoloC68:fix/plugin-name-case-sensitivity

Conversation

@PaoloC68
Copy link
Copy Markdown

@PaoloC68 PaoloC68 commented Apr 17, 2026

…filesystems

On Linux (case-sensitive filesystem), PLUGIN_NAME = "AutoDream" caused find_plugin_dir() to look for /usr/plugins/AutoDream/ which does not exist. The directory is named "autodream" (lowercase), matching plugin.yaml name field.

This caused get_plugin_config() to return None on every chain end, making config.get("enabled") falsy and silently short-circuiting the extension before any dream cycle could run.

Fix: lowercase PLUGIN_NAME to "autodream" in both affected files.

Summary by CodeRabbit

  • Bug Fixes
    • Fixed AutoDream plugin configuration loading to use correct identifier format, ensuring the plugin retrieves its settings properly.

…filesystems

On Linux (case-sensitive filesystem), PLUGIN_NAME = "AutoDream" caused
find_plugin_dir() to look for /usr/plugins/AutoDream/ which does not exist.
The directory is named "autodream" (lowercase), matching plugin.yaml name field.

This caused get_plugin_config() to return None on every chain end, making
config.get("enabled") falsy and silently short-circuiting the extension
before any dream cycle could run.

Fix: lowercase PLUGIN_NAME to "autodream" in both affected files.
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Apr 17, 2026

📝 Walkthrough

Walkthrough

Plugin configuration lookup keys are updated from PascalCase to lowercase across two files (_60_auto_dream.py and auto_dream.py) to maintain consistent naming convention for plugin identifier retrieval. The control flow and behavior remain unchanged.

Changes

Cohort / File(s) Summary
Plugin Configuration Key Alignment
extensions/python/process_chain_end/_60_auto_dream.py, helpers/auto_dream.py
Updated plugin identifier constant PLUGIN_NAME and corresponding configuration lookup key from "AutoDream" to "autodream" for consistent naming convention.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 With whiskers twitched and nose so keen,
I've spotted keys out of their scene,
From "AutoDream" to "autodream" so bright,
Consistency reigns—the naming's just right!

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The PR title accurately describes the main change: lowercasing PLUGIN_NAME to match the actual directory name on case-sensitive filesystems.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
extensions/python/process_chain_end/_60_auto_dream.py (1)

19-19: Consider reusing PLUGIN_NAME instead of duplicating the literal.

The lowercase value is correct; importing the existing constant would keep the config key single-sourced and make future renames safer.

♻️ Proposed cleanup
-from usr.plugins.autodream.helpers.auto_dream import schedule_auto_dream
+from usr.plugins.autodream.helpers.auto_dream import PLUGIN_NAME, schedule_auto_dream
@@
-        config = plugins.get_plugin_config("autodream", self.agent) or {}
+        config = plugins.get_plugin_config(PLUGIN_NAME, self.agent) or {}
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@extensions/python/process_chain_end/_60_auto_dream.py` at line 19, Replace
the hard-coded plugin name string in the call to
plugins.get_plugin_config("autodream", self.agent) with the shared constant
PLUGIN_NAME: import (or reference) PLUGIN_NAME from the module where it is
defined and call plugins.get_plugin_config(PLUGIN_NAME, self.agent) so the
config key is single-sourced and future renames stay consistent; keep the rest
of the line assigning to config unchanged.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In `@extensions/python/process_chain_end/_60_auto_dream.py`:
- Line 19: Replace the hard-coded plugin name string in the call to
plugins.get_plugin_config("autodream", self.agent) with the shared constant
PLUGIN_NAME: import (or reference) PLUGIN_NAME from the module where it is
defined and call plugins.get_plugin_config(PLUGIN_NAME, self.agent) so the
config key is single-sourced and future renames stay consistent; keep the rest
of the line assigning to config unchanged.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: a8aa6ff1-cc86-4aec-9da7-435b111386f9

📥 Commits

Reviewing files that changed from the base of the PR and between 01f2d82 and b4b291f.

📒 Files selected for processing (2)
  • extensions/python/process_chain_end/_60_auto_dream.py
  • helpers/auto_dream.py

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant