feat(d2-renderer): allow usage of svgs #34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`d2` relies on Playwright for SVG→PNG conversion, which requires Chromium. This change adds an option to use SVGs directly, avoiding the need to install Chromium for rendering certain diagrams. It also catches and silences a success message that `d2` writes to stderr.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
d2relies on Playwright for SVG→PNG conversion, which requires Chromium. This change adds an option to use SVGs directly, avoiding the need to install Chromium for rendering certain diagrams. It also catches and silences a success message thatd2writes to stderr.PS: Playwright is not supported on multiple platforms and with chromium extremely heavy