Skip to content

Fix issue, where we've generated non-existing names if a filename had a colon #98

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
onelxj merged 1 commit into from
Oct 6, 2025
Merged

Fix issue, where we've generated non-existing names if a filename had a colon #98

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion check-style.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,15 @@ case $1 in
esac

# Filter out symlinks from `affected_files`. We'll check the real files.
affected_files=$(echo "$affected_files" | xargs -r -n1 file | grep -v 'symbolic link' | cut -d: -f1 | tr '\n' ' ')
# Use bash test operators instead of the 'file' command to avoid issues with
# filenames containing special characters (colons, commas, etc).
filtered_files=""
for f in $affected_files; do
if [ ! -L "$f" ]; then
filtered_files="$filtered_files $f"
fi
done
affected_files=$(echo "$filtered_files" | xargs -r)

# Unset variable would be a sign of programmer error. We are not using '-e' in
# this script as we'd like to handle these cases ourselves where relevant, i.e.,
Expand Down