-
Notifications
You must be signed in to change notification settings - Fork 20
Adding Service Subscription and Service Plan resources and tests for Service Subscriptions #165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
3ab83e0
Adding Service Subscription and Service Plan resources and tests for …
c11872a
Changes made in response to PR comments.
josemacassan 8b9289d
Update tests for test_integration_service_subscriptions. Add Service …
josemacassan 405ad3c
Adding resources for Service Plan and the equivalent unit tests
josemacassan 4468b33
Implement suggested changes from PR review.
josemacassan c3741e4
Fix missing correct nammes in DefaultResoruce ServiceSubscription
josemacassan fe1c072
Fix minor bugs in PR after review.
josemacassan bf57f21
Fix typo in resources.py
josemacassan File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,32 @@ | ||
|
|
||
|
|
||
| from tests.integration import asserts | ||
|
|
||
| def test_list_service_plans(service): | ||
| resource = service.service_plans.list() | ||
| assert len(resource) >= 1 | ||
|
|
||
| def test_check_service_plan_creation(service_plan, service_plan_params): | ||
| asserts.assert_resource(service_plan) | ||
| asserts.assert_resource_params(service_plan, service_plan_params) | ||
| assert service_plan.exists() | ||
|
|
||
| def test_read_service_plans(service, service_plan, service_plan_params): | ||
| asserts.assert_resource(service_plan) | ||
| resource = service.service_plans.read(service_plan.entity_id) | ||
| asserts.assert_resource(resource) | ||
| asserts.assert_resource_params(service_plan,service_plan_params) | ||
|
|
||
| def test_update_service_plans(service, service_plan, service_plan_params): | ||
| asserts.assert_resource(service_plan) | ||
| service_plan['state'] = 'publish' | ||
| service_plan['approval_required'] = True | ||
| resource = service.service_plans.update(service_plan.entity_id, service_plan_params) | ||
| asserts.assert_resource(resource) | ||
| asserts.assert_resource_params(service_plan, service_plan_params) | ||
|
|
||
| def test_set_default_service_plan(service_plan, service_plan_params): | ||
| asserts.assert_resource(service_plan) | ||
| resource = service_plan.set_default() | ||
| asserts.assert_resource(resource) | ||
| asserts.assert_resource_params(service_plan, service_plan_params) |
16 changes: 16 additions & 0 deletions
16
tests/integration/test_integration_service_subscriptions.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,16 @@ | ||
|
|
||
|
|
||
| from tests.integration import asserts | ||
|
|
||
| def test_list_service_subscriptions(account): | ||
| resource = account.service_subscriptions.list() | ||
| assert len(resource) >= 1 | ||
|
|
||
| def test_create_service_subscription(service_subscription, service_subscription_params): | ||
| asserts.assert_resource(service_subscription) | ||
| asserts.assert_resource_params(service_subscription, service_subscription_params) | ||
|
|
||
| def test_read_service_subscription(account, service_subscription, service_subscription_params): | ||
| resource = account.service_subscriptions.read(service_subscription.entity_id) | ||
| asserts.assert_resource(resource) | ||
| asserts.assert_resource_params(service_subscription,service_subscription_params) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.