This repository was archived by the owner on Dec 19, 2023. It is now read-only.
Update SVGParser.java#1
Open
Anon-Artist wants to merge 1 commit into418sec:masterfrom
Open
Conversation
huntr-helper
pushed a commit
to 418sec/huntr
that referenced
this pull request
Feb 7, 2021
|
👋 Hello, @bonnyfone - @Anon-Artist has opened a PR to us with a fix for a potential vulnerability in your repository. To view the vulnerability, please refer to the bounty URL in the first comment, above. Ultimately, you get to decide if the fix is 👍 or 👎. If you are happy with the fix, please write a new comment ( If you have any questions or need support, come and join us on our community Discord! @bonnyfone & @Anon-Artist - thank you for your efforts in securing the world’s open source code! 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📊 Metadata *
VectAlign (a.k.a. VectorDrawableAlign) is a developer's tool which automagically aligns two VectorDrawable "pathData" strings (or SVG images) in order to allow morphing animations between them using an AnimatedVectorDrawable.
Bounty URL: https://www.huntr.dev/bounties/1-other-vectalign
⚙️ Description *
VectAlign (a.k.a. VectorDrawableAlign) is vulnerable to (XXE) Vulnerability.
💻 Technical Description *
OWASP recommends ACCESS_EXTERNAL_DTD and ACCESS_EXTERNAL_STYLESHEET but it's mainly centered for the TransformerFactory Parser. As it's implemented in DocumentBuilderFactory and has been used in other functions as well, I wrote a fix for it rather than switching to any other parsers.
🐛 Proof of Concept (PoC) *
*https://drive.google.com/drive/folders/1CLc0cYmz6Q-CGnMpDnupx7YTjNzo8Eir?usp=sharing
POC IMAGE
*https://drive.google.com/file/d/1VqfAgldmtY-qrgHRfizVvAH2oIFZVT-q/view
🔥 Proof of Fix (PoF) *
XXE is Fixed
👍 User Acceptance Testing (UAT)
After fix functionality is unaffected.
🔗 Relates to...
https://www.huntr.dev/bounties/1-other-vectalign