ack/nack messages in github service

[PaulicStudios]

No description provided.

[Copilot]

Pull Request Overview

This PR updates RabbitMQ service names from hyphenated to underscore format for consistency, while also adding error handling, message acknowledgment, and dead letter queue support to the GitHub service.

• Updates queue names from hyphen-separated to underscore-separated format (e.g., "github-service-results" → "github_service_results")
• Implements manual message acknowledgment and retry logic with dead letter queue support
• Adds custom error classes for better GitHub API error handling

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
github-service/src/main.ts	Adds RabbitMQ configuration options and dead letter queue setup
github-service/src/githubApi/index.ts	Exports new custom error classes
github-service/src/githubApi/client.ts	Implements custom error classes for GitHub API responses
github-service/src/app.service.ts	Updates queue name to use underscores
github-service/src/app.controller.ts	Adds message acknowledgment and retry logic for all event handlers
api/src/main.ts	Updates queue name to use underscores

---

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

[Copilot]

There's inconsistent spacing in the indentation. This line has 7 spaces while other similar lines use 8 spaces for consistent indentation.

[PaulicStudios]

okay @Peu77 there is another way to configure rabbitmq to handle the exchange into another queue after x amount of retires but you can not configure it in the code itself. So I would just stick to this approach

[Peu77]

okay @Peu77 there is another way to configure rabbitmq to handle the exchange into another queue after x amount of retires but you can not configure it in the code itself. So I would just stick to this approach

I'm sure you can configure it in the code, there must be a way

[PaulicStudios]

okay @Peu77 there is another way to configure rabbitmq to handle the exchange into another queue after x amount of retires but you can not configure it in the code itself. So I would just stick to this approach

I'm sure you can configure it in the code, there must be a way

yes via the http api. But that is even worse code than like that xD

[Peu77]

okay @Peu77 there is another way to configure rabbitmq to handle the exchange into another queue after x amount of retires but you can not configure it in the code itself. So I would just stick to this approach

I'm sure you can configure it in the code, there must be a way

yes via the http api. But that is even worse code than like that xD

can we not just do it like this:

export const getRabbitmqConfig: any = (configService: ConfigService, queue: string) => {
return {
transport: Transport.RMQ,
options: {
urls: [configService.getOrThrow("RABBITMQ_URL")],
queue: queue,
queueOptions: {
arguments: {
"x-queue-type": "quorum",
"x-max-length": 10000,
"x-dead-letter-exchange": ${queue}_dlx,
"x-max-delivery-count": 3
}
},
noAck: false,
prefetchCount: 1,
retryAttempts: 3,
retryDelay: 1000
}
}
}

[PaulicStudios]

okay @Peu77 there is another way to configure rabbitmq to handle the exchange into another queue after x amount of retires but you can not configure it in the code itself. So I would just stick to this approach

I'm sure you can configure it in the code, there must be a way

yes via the http api. But that is even worse code than like that xD

can we not just do it like this:

export const getRabbitmqConfig: any = (configService: ConfigService, queue: string) => { return { transport: Transport.RMQ, options: { urls: [configService.getOrThrow("RABBITMQ_URL")], queue: queue, queueOptions: { arguments: { "x-queue-type": "quorum", "x-max-length": 10000, "x-dead-letter-exchange": ${queue}_dlx, "x-max-delivery-count": 3 } }, noAck: false, prefetchCount: 1, retryAttempts: 3, retryDelay: 1000 } } }

I will try to do that

[Peu77]

test the solution I gave you

[Peu77]

okay @Peu77 there is another way to configure rabbitmq to handle the exchange into another queue after x amount of retires but you can not configure it in the code itself. So I would just stick to this approach

I'm sure you can configure it in the code, there must be a way

yes via the http api. But that is even worse code than like that xD

can we not just do it like this:
export const getRabbitmqConfig: any = (configService: ConfigService, queue: string) => { return { transport: Transport.RMQ, options: { urls: [configService.getOrThrow("RABBITMQ_URL")], queue: queue, queueOptions: { arguments: { "x-queue-type": "quorum", "x-max-length": 10000, "x-dead-letter-exchange": ${queue}_dlx, "x-max-delivery-count": 3 } }, noAck: false, prefetchCount: 1, retryAttempts: 3, retryDelay: 1000 } } }

I will try to do that

Is there any update here? Did you try that?