Update Dockerfile to use new poetry option --without dev #530
Closed
gabrielgaraujo wants to merge 1 commit into42school:masterfrom
Closed
Update Dockerfile to use new poetry option --without dev #530gabrielgaraujo wants to merge 1 commit into42school:masterfrom
gabrielgaraujo wants to merge 1 commit into42school:masterfrom
Conversation
dec06aa to
79e2786
Compare
79e2786 to
fec86a9
Compare
malallai
reviewed
Mar 31, 2025
| COPY pyproject.toml poetry.lock ./ | ||
|
|
||
| RUN pip3 install poetry \ | ||
| RUN pip3 install setuptools poetry==1.8.5 \ |
Collaborator
There was a problem hiding this comment.
Instead of locking Poetry to 1.8.5, could you just update the Dockerfile using the new --without dev syntax?
Contributor
Author
There was a problem hiding this comment.
I've adjusted the Dockerfile to fix the issue using the deprecated option and also cleanup some unecessary context copy during the image build.
I hope this helps.
d0d4a69 to
f330060
Compare
f330060 to
ebae3d0
Compare
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The option --no-dev was deprecated on poetry 2.0.0, also there are other breaking changes that I'm not able to quickly fix. So locking the version is what I can do.
python-poetry/poetry#8659