Skip to content

Update Dockerfile to use new poetry option --without dev #530

Closed
gabrielgaraujo wants to merge 1 commit into42school:masterfrom
gabrielgaraujo:lock-poetry-version
Closed

Update Dockerfile to use new poetry option --without dev #530
gabrielgaraujo wants to merge 1 commit into42school:masterfrom
gabrielgaraujo:lock-poetry-version

Conversation

@gabrielgaraujo
Copy link
Copy Markdown
Contributor

The option --no-dev was deprecated on poetry 2.0.0, also there are other breaking changes that I'm not able to quickly fix. So locking the version is what I can do.

python-poetry/poetry#8659

@gabrielgaraujo gabrielgaraujo force-pushed the lock-poetry-version branch 3 times, most recently from dec06aa to 79e2786 Compare March 1, 2025 15:19
@malallai malallai force-pushed the lock-poetry-version branch from 79e2786 to fec86a9 Compare March 31, 2025 08:39
Comment thread Dockerfile Outdated
COPY pyproject.toml poetry.lock ./

RUN pip3 install poetry \
RUN pip3 install setuptools poetry==1.8.5 \
Copy link
Copy Markdown
Collaborator

@malallai malallai Mar 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of locking Poetry to 1.8.5, could you just update the Dockerfile using the new --without dev syntax?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've adjusted the Dockerfile to fix the issue using the deprecated option and also cleanup some unecessary context copy during the image build.

I hope this helps.

@gabrielgaraujo gabrielgaraujo requested a review from malallai April 14, 2025 16:49
@gabrielgaraujo gabrielgaraujo changed the title Lock poetry version to 1.8.5 Update Dockerfile to use new --without dev poetry option Apr 14, 2025
@gabrielgaraujo gabrielgaraujo changed the title Update Dockerfile to use new --without dev poetry option Update Dockerfile to use new poetry option --without dev Apr 14, 2025
@malallai
Copy link
Copy Markdown
Collaborator

malallai commented Jun 6, 2025

Hello,

Sorry for the late review. Since @NiumXp made changes in another PR (#548), this one is now outdated and no longer relevant.

Thanks a lot for your work!

I'm closing this PR.

@malallai malallai closed this Jun 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants