Check for None in IsFunctionCall#552
Open
MFelida wants to merge 1 commit into42school:masterfrom
Open
Conversation
Asandolo
force-pushed
the
hangs_on_macro_function
branch
from
6194b1b to
063469a
Compare
Asandolo
reviewed
Jun 6, 2025
Collaborator
Asandolo
left a comment
Asandolo
left a comment
There was a problem hiding this comment.
Hello can you add test for you changes please
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issues Fixed
Verification Steps
poetry run flake8to check for linting issues.poetry run pytestto ensure unit tests pass.poetry run toxto validate compatibility across Python versions.Additional Notes
Macro functions aren't allowed in the norm and every other function needs to be followed by semicolon, so I think it's fine to just error out of norminette when semicolon isn't found. Hitting an exception is better than hanging at the very least.