Skip to content

feat: allow ternary in define with -R CheckDefine#560

Merged
Asandolo merged 1 commit intomasterfrom
malo/IN-5461-allow-ternary-in-define-with-r-checkdefine
Jun 6, 2025
Merged

feat: allow ternary in define with -R CheckDefine#560
Asandolo merged 1 commit intomasterfrom
malo/IN-5461-allow-ternary-in-define-with-r-checkdefine

Conversation

@malallai
Copy link
Copy Markdown
Collaborator

@malallai malallai commented Jun 4, 2025

Jira Issues Fixed

  • Closes IN-5461

Resume of the Jira ticket :

We have a pisciner who submitted the code below to validate the ft_abs.h which pisciners needs to create macro from the code below. Pisciner has submitted the code below but the norminette >=3.3.51 doesn’t pass. But the next one pass.

# define ABS(Value) Value < 0 ? -Value : Value
# define ABS(Value) Value * (Value >= 0) + -Value * (Value < 0)

It’s quite complicated as exercise if they need to think this kind of code to validate the exercises.


@boulon42
Copy link
Copy Markdown

boulon42 commented Jun 4, 2025

Ok for me

@boulon42 boulon42 self-requested a review June 4, 2025 07:11
@Asandolo Asandolo merged commit df6f9c9 into master Jun 6, 2025
4 checks passed
@Asandolo Asandolo deleted the malo/IN-5461-allow-ternary-in-define-with-r-checkdefine branch June 6, 2025 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants