This repository was archived by the owner on Jan 11, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 38
Makefile improvements #4
Open
tommai78101
wants to merge
24
commits into
44670:master
Choose a base branch
from
tommai78101:makefile
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
> <@profi200> It's borked beyond repair. Not sure you will get any standard build system working with it.
Added a TODO item to the Readme.md
replace python build "system" with Makefile
* old_3ds - For old 3ds * new_3ds - For new 3ds * both - For both devices.
dbe1e87 to
3588aee
Compare
2d78a0d to
e97a519
Compare
…stdarg.h> around.
(cherry picked from commit f5a30cb)
# Conflicts: # README.md
Readme fix.
Warnings removal
Contributor
Author
|
On second thought, this Makefile improvement isn't really improving the build flow. What it does right now is, it runs Make twice, overriding the NEW_3DS flag set in the previous Make run, thus ignoring the DSP path to be compiled using -Os. I may need to rethink this at a later time. |
Contributor
Author
|
Going by WinterMute's suggestion, I added @44670, what do you think about the |
…the Makefile to compensate.
a47daae to
28227d4
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes: