Skip to content

Let ParameterList survive lin-solver builder#1628

Merged
amgebauer merged 1 commit into4C-multiphysics:mainfrom
amgebauer:fix-segfault-in-trilinos-debug
Dec 23, 2025
Merged

Let ParameterList survive lin-solver builder#1628
amgebauer merged 1 commit into4C-multiphysics:mainfrom
amgebauer:fix-segfault-in-trilinos-debug

Conversation

@amgebauer
Copy link
Copy Markdown
Member

@amgebauer amgebauer commented Dec 23, 2025

Cherry-pick from #1600

Avoids a segmentation fault when compiling with Trilinos in debug mode. The ParameterList needs to outlive the LinearSolverBuilder.

@amgebauer amgebauer enabled auto-merge December 23, 2025 16:14
@maxfirmbach
Copy link
Copy Markdown
Contributor

maxfirmbach commented Dec 23, 2025

Does this also hold true for the MueLu and Teko adapters? I think there it is done in a similar fashion.

@amgebauer
Copy link
Copy Markdown
Member Author

amgebauer commented Dec 23, 2025

In MueLu and Teko, we do it differently: We create an actual owning RCP that goes into Statimikos. In that case it is fine since the lifetime of the ParameterList is then managed by the RCP.

@amgebauer amgebauer merged commit c5ac79b into 4C-multiphysics:main Dec 23, 2025
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mayrmt mayrmt mayrmt approved these changes

@maxfirmbach maxfirmbach maxfirmbach approved these changes

@c-p-schmidt c-p-schmidt c-p-schmidt approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@amgebauer @maxfirmbach @mayrmt @c-p-schmidt