Skip to content

Fix browndynamic tests for Trilinos assertions#1639

Merged
amgebauer merged 1 commit into4C-multiphysics:mainfrom
amgebauer:fix-browndyn-tests
Dec 30, 2025
Merged

Fix browndynamic tests for Trilinos assertions#1639
amgebauer merged 1 commit into4C-multiphysics:mainfrom
amgebauer:fix-browndyn-tests

Conversation

@amgebauer
Copy link
Copy Markdown
Member

This fixes the failing browndyn tests in #1600.

Copy link
Copy Markdown
Contributor

@davidrudlstorfer davidrudlstorfer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for investigating this and also the fix :)

Out of curiosity - what was wrong here or rather what was the problem so I can understand the fix :D

@amgebauer
Copy link
Copy Markdown
Member Author

the binding spot forces were only created with a size of 1 row and never resized. Here and here, they were accessed with the actual spatial dimensions, which is 3.

You have to decide whether 3 is correct for the binding spot forces. It might be 6 to include moments? At least accessed are only the first 3 entries.

@davidrudlstorfer
Copy link
Copy Markdown
Contributor

the binding spot forces were only created with a size of 1 row and never resized. Here and here, they were accessed with the actual spatial dimensions, which is 3.

You have to decide whether 3 is correct for the binding spot forces. It might be 6 to include moments? At least accessed are only the first 3 entries.

Thanks for the explanation :) Makes total sense. 3 should be correct. Based on the file names the code occurrences only happen in trusses and jointed pins, these should only be able to transmit forces.

Thanks for the fix and explanation 🚀

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request fixes failing browndynamic tests by properly specifying the size parameter when constructing SerialDenseVector objects in beam interaction link classes. The changes ensure compatibility with Trilinos debug assertions enabled in PR #1600.

Key changes:

  • Added explicit size parameter (3) to SerialDenseVector constructors in beam link initialization
  • Fixed constructor calls in both default constructors and copy constructors
  • Applied consistently across three beam link classes

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
src/beaminteraction/src/4C_beaminteraction_link_truss.cpp Added size parameter (3) to SerialDenseVector initialization in both constructors for the truss beam link class
src/beaminteraction/src/4C_beaminteraction_link_beam3_reissner_line2_rigidjointed.cpp Added size parameter (3) to SerialDenseVector initialization in both constructors for the rigid-jointed beam link class
src/beaminteraction/src/4C_beaminteraction_link_beam3_reissner_line2_pinjointed.cpp Added size parameter (3) to SerialDenseVector initialization in both constructors for the pin-jointed beam link class

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@amgebauer amgebauer merged commit a292a70 into 4C-multiphysics:main Dec 30, 2025
57 of 59 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants