Open
Conversation
Contributor
Author
|
@sebproell What do you think about the |
maxfirmbach
added
type: enhancement
amgebauer
reviewed
Jan 9, 2026
sebproell
reviewed
Jan 9, 2026
| fetchcontent_makeavailable(libqhull) | ||
| set(FOUR_C_QHULL_ROOT "${CMAKE_INSTALL_PREFIX}") | ||
|
|
||
| four_c_add_external_dependency(four_c_all_enabled_external_dependencies qhull_r) |
Member
There was a problem hiding this comment.
Suggested change
| four_c_add_external_dependency(four_c_all_enabled_external_dependencies qhull_r) | |
| four_c_add_external_dependency(four_c_all_enabled_external_dependencies QHull::qhull_r) |
Does this work? I am looking at https://github.com/qhull/qhull/blob/master/CMakeLists.txt#L744, which gives an export namespace but unfortunately they do not alias the qhull_r target as QHull::qhull_r. Maybe we need to do this ourselves here.
Also, QHull is still installed in the image, right? I think the wrong one is picked up during the install test: https://github.com/4C-multiphysics/4C/actions/runs/20850200696/job/59903586127?pr=1649#step:9:46
which would give you a pretty random result. I would drop the QHull from the image. Afterwards, you probably need to fix the install process here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description and Context
Lets see if this works.
Related Issues and Pull Requests