Skip to content

Remove untested penalty-based 3D multipoint constraint#1774

Merged
lauraengelhardt merged 1 commit into4C-multiphysics:mainfrom
lauraengelhardt:remove-untested-penalty-multipoint-constraint
Feb 27, 2026
Merged

Remove untested penalty-based 3D multipoint constraint#1774
lauraengelhardt merged 1 commit into4C-multiphysics:mainfrom
lauraengelhardt:remove-untested-penalty-multipoint-constraint

Conversation

@lauraengelhardt
Copy link
Copy Markdown
Contributor

@lauraengelhardt lauraengelhardt commented Feb 19, 2026 •
edited
Loading

Description and Context

The condition DESIGN SURFACE NORMALDIR MULTIPNT CONSTRAINT 3D PEN is not tested.

We should either test it or remove it. Most multipoint constraints implemented within the constraint framework don't work with the Standard structural time integration (see #210 (comment)). So - even when testing it - we would need to fix some things there when moving to the Standard structural time integration.

I thus suggest to remove the condition, if there are no objections.

We have still have DESIGN POINT COUPLING CONDITION (that also works with the Standard structural time integration) and DESIGN SURFACE NORMALDIR MULTIPNT CONSTRAINT 3D (currently only working with Old.

@lauraengelhardt lauraengelhardt self-assigned this Feb 19, 2026
@mayrmt
Copy link
Copy Markdown
Member

mayrmt commented Feb 19, 2026

@m-frey @isteinbrecher @eulovi What's your take on this?

@m-frey
Copy link
Copy Markdown
Contributor

m-frey commented Feb 21, 2026 •
edited
Loading

This functionality is duplicative here anyway, as it is also implemented in the constraint_framework model evaluator. At the moment, it is only used and tested there in 2D. However, there is an open pr (#1751) to extend the implementation to 3D. So I have no objections to removing it here.

@lauraengelhardt
Remove untested multipoint constraint 3D penalty
df3198a 
Remove the condition
DESIGN SURFACE NORMALDIR MULTIPNT CONSTRAINT 3D PEN
as it is untested.
@lauraengelhardt lauraengelhardt force-pushed the remove-untested-penalty-multipoint-constraint branch from 6727b3d to df3198a Compare February 22, 2026 12:23
@isteinbrecher
Copy link
Copy Markdown
Contributor

isteinbrecher commented Feb 23, 2026

@m-frey @isteinbrecher @eulovi What's your take on this?

I have never used this functionality, so I am fine with removing it.

@eulovi
Copy link
Copy Markdown
Contributor

eulovi commented Feb 23, 2026

@m-frey @isteinbrecher @eulovi What's your take on this?

I am also fine removing this, as I don't use this functionality.

@lauraengelhardt
Copy link
Copy Markdown
Contributor Author

lauraengelhardt commented Feb 23, 2026

Nice, thanks for your feedback! I fixed the failing pipeline, so this would be ready from my side 😃

@m-frey
Copy link
Copy Markdown
Contributor

m-frey commented Feb 23, 2026

@ischeider are you using this ?

@lauraengelhardt
Copy link
Copy Markdown
Contributor Author

lauraengelhardt commented Feb 27, 2026

Can I get a second review here, please?

@lauraengelhardt lauraengelhardt merged commit 597ed12 into 4C-multiphysics:main Feb 27, 2026
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@isteinbrecher isteinbrecher isteinbrecher approved these changes

@maxfirmbach maxfirmbach maxfirmbach approved these changes

@eulovi eulovi Awaiting requested review from eulovi

@m-frey m-frey Awaiting requested review from m-frey

Assignees

@lauraengelhardt lauraengelhardt

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@lauraengelhardt @mayrmt @m-frey @isteinbrecher @eulovi @maxfirmbach