Isolate global problem in more places#1908
Open
bgoderbauer wants to merge 5 commits into4C-multiphysics:mainfrom
Open
Isolate global problem in more places#1908bgoderbauer wants to merge 5 commits into4C-multiphysics:mainfrom
bgoderbauer wants to merge 5 commits into4C-multiphysics:mainfrom
Conversation
bgoderbauer
added
the
taskforce: modularization
bgoderbauer
force-pushed
the
isolate-global-problem
branch
from
22f5a9f to
e21b1d9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes ~450 direct
Global::Problem()calls. Contrary to e.g. #1899, no problem-specific context is introduced. These changes just bundle the calls per module into a single, obvious choke point (the respectiveproblem_from_instance()methods) that can be easily replaced with the context-driven setup later.Note: adapter and fsi still have other calls to Global::Problem() left, but they don't directly belong to the changed routines