Feature | Add note column to reviewer overview#27
Draft
gabrielakuhn wants to merge 1 commit intomainfrom
Draft
Conversation
2f98b3e to
917ceea
Compare
Contributor
|
Hi @gabrielakuhn! The PR looks very well done! I added an inline comment to the PR, and I'm looking forward to see if that idea of treating an empty string as an implicit delete of the note will work out. :-) |
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
roelj
reviewed
May 9, 2025
This comment was marked as off-topic.
This comment was marked as off-topic.
917ceea to
50eb533
Compare
This comment was marked as resolved.
This comment was marked as resolved.
dbcae9a to
ed7750c
Compare
roelj
reviewed
May 16, 2025
ed7750c to
60448cc
Compare
gabrielakuhn
commented
May 20, 2025
b18ea9e to
af8c285
Compare
26e9b13 to
1109e93
Compare
1109e93 to
d37372a
Compare
d37372a to
c3c44a2
Compare
Collaborator
Author
|
Latest change: we now use a |
* src/djehuty/web/database.py: Implement database procedure for update and delete a note and add check for RDF.nil in normalize biding. * src/djehuty/web/formatter.py: Add note, submitter_account_uuid and reviewer_account_uuid to the response format * src/djehuty/web/resources/html_templates/colors.css: Add global scope variables for gray colors * src/djehuty/web/resources/html_templates/review/overview.html: Add note column to review table and styles * src/djehuty/web/resources/sparql_templates/reviews.sparql: Add review note, submitter_account_uuid and reviewer_account_uuid to the return values for reviews * src/djehuty/web/resources/sparql_templates/update_review.sparql: Modify sparql update template to include update of a note * src/djehuty/web/resources/static/js/review-overview.js: Implement logic for adding, editing, and deleting notes and add note to copy row functionality * src/djehuty/web/wsgi.py: implement update review note method
fe2f0dd to
a5e51c6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add a new
note fieldto the Review Overview table and display it as a column in the table.Update the “Copy row” functionality to include the note value when copying row data.
Changes
Approval Checklist
Issue Reference
We want to identify and implement new features in the deposit and publication workflow to make it easier and more efficient for users and data curators. Part of #43
Screenshots