Skip to content

Feature | Add note column to reviewer overview#27

Draft
gabrielakuhn wants to merge 1 commit intomainfrom
feature/note-column-reviewer-overview
Draft

Feature | Add note column to reviewer overview#27
gabrielakuhn wants to merge 1 commit intomainfrom
feature/note-column-reviewer-overview

Conversation

@gabrielakuhn
Copy link
Copy Markdown
Collaborator

@gabrielakuhn gabrielakuhn commented May 2, 2025

Summary
Add a new note field to the Review Overview table and display it as a column in the table.
Update the “Copy row” functionality to include the note value when copying row data.

Changes

  • src/djehuty/web/database.py: Implement database procedure for update and delete a note using sentinel value and add check for RDF.nil in normalize biding.
  • src/djehuty/web/formatter.py: Add note, submitter_account_uuid and reviewer_account_uuid to the response format
  • src/djehuty/web/resources/html_templates/colors.css: Add global scope variables for gray colors
  • src/djehuty/web/resources/html_templates/review/overview.html: Add note column to review table and styles
  • src/djehuty/web/resources/sparql_templates/reviews.sparql: Add review note, submitter_account_uuid and reviewer_account_uuid to the return values for reviews
  • src/djehuty/web/resources/sparql_templates/update_review.sparql: Modify sparql update template to include update of a note
  • src/djehuty/web/resources/static/js/review-overview.js: Implement logic for adding, editing, and deleting notes and add note to copy row functionality
  • src/djehuty/web/wsgi.py: implement update review note method

Approval Checklist

  • I agree to follow Djehuty's code of conduct.
  • I have read and I have follow the code contribution workflow.
  • Code style and conventions were respected.
  • Documentation has been updated where needed (README, docs, or examples).
  • Review approved by at least one maintainer.
  • Merge readiness (PR is squashed into a single commit and follows the commit template).

Issue Reference
We want to identify and implement new features in the deposit and publication workflow to make it easier and more efficient for users and data curators. Part of #43

Screenshots

image

@gabrielakuhn gabrielakuhn requested a review from roelj May 2, 2025 15:44
@gabrielakuhn gabrielakuhn force-pushed the feature/note-column-reviewer-overview branch from 2f98b3e to 917ceea Compare May 6, 2025 07:18
@roelj roelj self-assigned this May 8, 2025
@roelj
Copy link
Copy Markdown
Contributor

roelj commented May 8, 2025

Hi @gabrielakuhn! The PR looks very well done! I added an inline comment to the PR, and I'm looking forward to see if that idea of treating an empty string as an implicit delete of the note will work out. :-)

@gabrielakuhn

This comment was marked as off-topic.

@roelj

This comment was marked as off-topic.

@gabrielakuhn

This comment was marked as off-topic.

Comment thread src/djehuty/web/wsgi.py
Comment thread src/djehuty/web/wsgi.py
@roelj

This comment was marked as off-topic.

@gabrielakuhn gabrielakuhn self-assigned this May 9, 2025
@gabrielakuhn gabrielakuhn force-pushed the feature/note-column-reviewer-overview branch from 917ceea to 50eb533 Compare May 9, 2025 13:53
@gabrielakuhn

This comment was marked as resolved.

@gabrielakuhn gabrielakuhn force-pushed the feature/note-column-reviewer-overview branch 2 times, most recently from dbcae9a to ed7750c Compare May 9, 2025 14:11
@roelj roelj marked this pull request as draft May 15, 2025 07:19
Comment thread src/djehuty/web/wsgi.py
Comment thread src/djehuty/web/resources/sparql_templates/update_review.sparql
Comment thread src/djehuty/web/resources/static/js/review-overview.js
@gabrielakuhn gabrielakuhn force-pushed the feature/note-column-reviewer-overview branch from ed7750c to 60448cc Compare May 20, 2025 13:13
Comment thread src/djehuty/web/resources/sparql_templates/update_review.sparql Outdated
@gabrielakuhn gabrielakuhn force-pushed the feature/note-column-reviewer-overview branch 2 times, most recently from b18ea9e to af8c285 Compare May 27, 2025 12:41
@gabrielakuhn gabrielakuhn force-pushed the feature/note-column-reviewer-overview branch 4 times, most recently from 26e9b13 to 1109e93 Compare June 10, 2025 10:31
@gabrielakuhn gabrielakuhn force-pushed the feature/note-column-reviewer-overview branch from 1109e93 to d37372a Compare July 3, 2025 07:38
@gabrielakuhn gabrielakuhn force-pushed the feature/note-column-reviewer-overview branch from d37372a to c3c44a2 Compare February 10, 2026 14:53
@gabrielakuhn
Copy link
Copy Markdown
Collaborator Author

Latest change: we now use a _UNSET as a sentinel value instead of rdf:nil when the note value is not provided.
rdf:nil means empty RDF list, so using it to signal “no value” was misleading. It’s also good RDF practice to do not have a triple at all when a value does not exist.

@gabrielakuhn gabrielakuhn removed the request for review from mdesmaele February 10, 2026 15:28
@gabrielakuhn gabrielakuhn marked this pull request as ready for review February 10, 2026 15:29
* src/djehuty/web/database.py: Implement database procedure for update and
  delete a note and add check for RDF.nil in normalize biding.
* src/djehuty/web/formatter.py: Add note, submitter_account_uuid and
  reviewer_account_uuid to the response format
* src/djehuty/web/resources/html_templates/colors.css: Add global scope
  variables for gray colors
* src/djehuty/web/resources/html_templates/review/overview.html: Add note
  column to review table and styles
* src/djehuty/web/resources/sparql_templates/reviews.sparql: Add review note,
  submitter_account_uuid and reviewer_account_uuid to the return values for
  reviews
* src/djehuty/web/resources/sparql_templates/update_review.sparql: Modify
  sparql update template to include update of a note
* src/djehuty/web/resources/static/js/review-overview.js: Implement logic
  for adding, editing, and deleting notes and add note to copy row functionality
* src/djehuty/web/wsgi.py: implement update review note method
@gabrielakuhn gabrielakuhn force-pushed the feature/note-column-reviewer-overview branch from fe2f0dd to a5e51c6 Compare February 11, 2026 12:33
@gabrielakuhn gabrielakuhn marked this pull request as draft February 19, 2026 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants