Skip to content

Allow creation of Metric from data structure without __name__ #306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Allow creation of Metric from data structure without __name__ #306

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions prometheus_api_client/metric.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,10 +54,9 @@ def __init__(self, metric, oldest_data_datetime=None):
self.metric_values = metric.metric_values
self.oldest_data_datetime = oldest_data_datetime
else:
self.metric_name = metric["metric"]["__name__"]
self.metric_name = metric["metric"].pop("__name__", None)
self.label_config = deepcopy(metric["metric"])
self.oldest_data_datetime = oldest_data_datetime
del self.label_config["__name__"]

# if it is a single value metric change key name
if "value" in metric:
Expand Down
Loading