Skip to content

Category organization#677

Merged
4tal merged 3 commits into4tals:mainfrom
ohadschn:category-reorg
Dec 2, 2023
Merged

Category organization#677
4tal merged 3 commits into4tals:mainfrom
ohadschn:category-reorg

Conversation

@ohadschn
Copy link
Copy Markdown
Collaborator

@ohadschn ohadschn commented Dec 2, 2023

Closes #610
Closes #320

Tested on my fork: ohadschn#53

More category organization

some more organization

generate [sub]category list
@vercel
Copy link
Copy Markdown

vercel bot commented Dec 2, 2023

@github-actions[bot] is attempting to deploy a commit to the 4tals Team on Vercel.

A member of the Team first needs to authorize it.

@vercel
Copy link
Copy Markdown

vercel bot commented Dec 2, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
iron-links ❌ Failed (Inspect) Dec 2, 2023 10:04am

@ohadschn
Copy link
Copy Markdown
Collaborator Author

ohadschn commented Dec 2, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
iron-links ❌ Failed (Inspect) Dec 2, 2023 10:04am

EDIT - I understand now, it just ran on a stale commit, this issue was fixed, approve Vercel again and we should be good.
Repro: https://github.com/ohadschn/ConnectPortal/actions/runs/7071067029/job/19248385208

@4tal Not sure what the issue was, it's not the mechanism we use for prod deployment so that shouldn't break (we build on GitHub actions - not the Vercel server, for such reasons exactly).

The better test is this: https://github.com/4tals/LinksForIsrael/actions/runs/7070546959/job/19247350107
Which passed and you can see the preview here: https://iron-links-c1bbuz76c-4tals.vercel.app/

Having said that, we wouldn't want the Vercel build / bot flow to be broken from now on, so assuming this wasn't transient (I recommend a retry) - please paste all the logs from the Vercel build (which I don't have access to, and on my Vercel it works), and I'll try and figure out the issue.

@4tal
Copy link
Copy Markdown
Collaborator

4tal commented Dec 2, 2023

Failed to compile.
12:18:03.112 |  
12:18:03.112 | ./_data/links/StrategicCommunication/Main/links.json
12:18:03.112 | Module parse failed: Cannot parse JSON: Unexpected token "]" (0x5D) in JSON at position 9257 while parsing near "...:34+02:00"\n },\n ]\n}\n"
12:18:03.112 | You may need an appropriate loader to handle this file type, currently no loaders are configured to process this file. See https://webpack.js.org/concepts#loaders
12:18:03.112 | Error: Cannot parse JSON: Unexpected token "]" (0x5D) in JSON at position 9257 while parsing near "...:34+02:00"\n },\n ]\n}\n"
12:18:03.112 | at JsonParser.parse (/vercel/path0/node_modules/.pnpm/next@14.0.3_react-dom@18.2.0_react@18.2.0_sass@1.69.5/node_modules/next/dist/compiled/webpack/bundle5.js:28:997642)
12:18:03.112 | at /vercel/path0/node_modules/.pnpm/next@14.0.3_react-dom@18.2.0_react@18.2.0_sass@1.69.5/node_modules/next/dist/compiled/webpack/bundle5.js:28:403525
12:18:03.112 | at processResult (/vercel/path0/node_modules/.pnpm/next@14.0.3_react-dom@18.2.0_react@18.2.0_sass@1.69.5/node_modules/next/dist/compiled/webpack/bundle5.js:28:399309)
12:18:03.112 | at /vercel/path0/node_modules/.pnpm/next@14.0.3_react-dom@18.2.0_react@18.2.0_sass@1.69.5/node_modules/next/dist/compiled/webpack/bundle5.js:28:400370
12:18:03.112 | at /vercel/path0/node_modules/.pnpm/next@14.0.3_react-dom@18.2.0_react@18.2.0_sass@1.69.5/node_modules/next/dist/compiled/loader-runner/LoaderRunner.js:1:8727
12:18:03.112 | at iterateNormalLoaders (/vercel/path0/node_modules/.pnpm/next@14.0.3_react-dom@18.2.0_react@18.2.0_sass@1.69.5/node_modules/next/dist/compiled/loader-runner/LoaderRunner.js:1:5565)
12:18:03.112 | at /vercel/path0/node_modules/.pnpm/next@14.0.3_react-dom@18.2.0_react@18.2.0_sass@1.69.5/node_modules/next/dist/compiled/loader-runner/LoaderRunner.js:1:5426
12:18:03.112 | at /vercel/path0/node_modules/.pnpm/next@14.0.3_react-dom@18.2.0_react@18.2.0_sass@1.69.5/node_modules/next/dist/compiled/webpack/bundle5.js:28:399845
12:18:03.112 | at eval (eval at create (/vercel/path0/node_modules/.pnpm/next@14.0.3_react-dom@18.2.0_react@18.2.0_sass@1.69.5/node_modules/next/dist/compiled/webpack/bundle5.js:13:28867), :14:1)
12:18:03.112 | at /vercel/path0/node_modules/.pnpm/next@14.0.3_react-dom@18.2.0_react@18.2.0_sass@1.69.5/node_modules/next/dist/build/webpack/plugins/profiling-plugin.js:168:29
12:18:03.112 |  
12:18:03.112 | Import trace for requested module:
12:18:03.112 | ./_data/links/StrategicCommunication/Main/links.json
12:18:03.113 | ./_data/links/ lazy ^./.*/links.json$ namespace object
12:18:03.113 | ./app/utils/categories.ts
12:18:03.113 | ./app/layout.tsx
12:18:03.113 |  
12:18:03.113 |  
12:18:03.113 | > Build failed because of webpack errors
12:18:03.163 | ELIFECYCLE  Command failed with exit code 1.
12:18:03.182 | Error: Command "pnpm run build" exited with 1
12:18:03.673


@4tal 4tal merged commit fe12821 into 4tals:main Dec 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Category names do not match their content Consider splitting the "hosting" category to "family hosting" and "evacuees support"

2 participants