Skip to content

Fix broken icon for SuppliesAndTransportation category#728

Merged
4tal merged 1 commit into4tals:mainfrom
4tala:fix/supplies-icon
Feb 8, 2026
Merged

Fix broken icon for SuppliesAndTransportation category#728
4tal merged 1 commit into4tals:mainfrom
4tala:fix/supplies-icon

Conversation

@4tala
Copy link
Copy Markdown
Contributor

@4tala 4tala commented Feb 8, 2026

The iconduck.com icon URL for ציוד/מזון ושינוע was unreachable/timing out.

Replaced with a reliable flaticon CDN icon (delivery truck).

Before: https://static-00.iconduck.com/assets.00/supply-chain-management-icon-2048x1937-54eit1e1.png (broken)
After: https://cdn-icons-png.flaticon.com/512/2769/2769339.png (working)

@netlify
Copy link
Copy Markdown

netlify bot commented Feb 8, 2026

Deploy Preview for linksforisrael ready!

Name Link
🔨 Latest commit bf39f7e
🔍 Latest deploy log https://app.netlify.com/projects/linksforisrael/deploys/6988795c5437e70008ffab8b
😎 Deploy Preview https://deploy-preview-728--linksforisrael.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@qodo-code-review
Copy link
Copy Markdown

Review Summary by Qodo

Fix broken icon for SuppliesAndTransportation category

🐞 Bug fix

Grey Divider

Walkthroughs

Description
• Replace broken iconduck.com icon URL with working flaticon CDN link
• Fixes unreachable icon for SuppliesAndTransportation category
Diagram
flowchart LR
  A["Broken iconduck URL"] -- "Replace with" --> B["Working flaticon CDN URL"]
Loading

Grey Divider

File Changes

1. _data/links/SuppliesAndTransportation/links.json 🐞 Bug fix +1/-1

Replace broken icon URL with working CDN link

• Updated image field URL from unreachable iconduck.com source to reliable flaticon CDN
• Changed from supply-chain-management icon to delivery truck icon
• Maintains all other category metadata unchanged

_data/links/SuppliesAndTransportation/links.json


Grey Divider

Qodo Logo

@4tal 4tal merged commit 8d76e38 into 4tals:main Feb 8, 2026
5 checks passed
@qodo-code-review
Copy link
Copy Markdown

Code Review by Qodo

🐞 Bugs (2) 📘 Rule violations (0) 📎 Requirement gaps (0)

Grey Divider


Remediation recommended

1. No icon fallback 🐞 Bug ⛯ Reliability
Description
• The PR changes the category icon to a new external URL; if it 404s / becomes unreachable, the
  category tile will render a broken image.
• Category icons currently have no error handling/fallback, while other UI images (initiative
  images) already implement an onError fallback pattern.
Code

_data/links/SuppliesAndTransportation/links.json[5]

+  "image": "https://cdn-icons-png.flaticon.com/512/2769/2769339.png",
Evidence
The updated category descriptor sets a remote image URL. The categories UI renders this URL directly
via Chakra UI’s <Image> without any fallback/onError handling. In contrast, initiative images
explicitly implement an onError fallback, indicating the codebase already recognizes and mitigates
this failure mode elsewhere.

_data/links/SuppliesAndTransportation/links.json[1-10]
app/components/Categories/CategoriesList.tsx[71-80]
app/components/Initiative/InitiativeItem.tsx[57-87]

Agent prompt
The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

## Issue description
Category icons are rendered from `category.image` (remote URL). If the URL fails to load, the UI shows a broken image because there’s no fallback.

## Issue Context
The PR updates the SuppliesAndTransportation category icon to a new external URL; this increases the chance of a user-visible broken icon if the new resource becomes unavailable.

## Fix Focus Areas
- app/components/Categories/CategoriesList.tsx[71-80]
- public/logo.svg[1-1]

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools



Advisory comments

2. Icon URLs not monitored 🐞 Bug ✧ Quality
Description
• The scheduled link-availability checker intentionally skips JSON files without a links array
  (category descriptor files), so category-level image URLs are never checked.
• This PR changes one of those unmonitored URLs; if it breaks later, the existing monitoring job
  won’t alert.
Code

_data/links/SuppliesAndTransportation/links.json[5]

+  "image": "https://cdn-icons-png.flaticon.com/512/2769/2769339.png",
Evidence
The availability monitor only processes initiative JSON files (those with a links array). Category
descriptors (which contain the image field updated by this PR) are explicitly skipped, so category
icon availability isn’t observed by the monitoring workflow.

scripts/link-availability/checkLinkAvailability.js[100-103]
_data/links/SuppliesAndTransportation/links.json[1-10]

Agent prompt
The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

## Issue description
The link availability monitor does not check category descriptor files, so category `image` URLs can break without detection.

## Issue Context
This is a pre-existing monitoring gap affecting all categories; this PR changes one such icon URL, making the gap more immediately relevant.

## Fix Focus Areas
- scripts/link-availability/checkLinkAvailability.js[97-104]
- _data/links/SuppliesAndTransportation/links.json[1-10]

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools


Grey Divider

ⓘ The new review experience is currently in Beta. Learn more

Grey Divider

Qodo Logo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants