add option to log payload #2966
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
DatGuyJonathan
force-pushed
the
add-logs-for-the-received-payloads-to-the-ingest-api-and-data-inout-of
branch
from
d497bc7 to
19200ff
Compare
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
packages/py-moose-lib/moose_lib/streaming/streaming_function_runner.py
Outdated
Show resolved
Hide resolved
callicles
reviewed
Nov 13, 2025
| debug!("parsed json array for {}", topic_name); | ||
|
|
||
| // Log payload if enabled (compact JSON on one line) | ||
| if std::env::var("MOOSE_LOG_PAYLOADS") |
Collaborator
There was a problem hiding this comment.
Could we preload it?
This will get re-executed for every requests which we get a lot of
Collaborator
There was a problem hiding this comment.
Also shouldn't that be passed through the cli flag?
| info!("Moose Version: {}", CLI_VERSION); | ||
|
|
||
| // Set environment variable for payload logging if flag is enabled | ||
| if *log_payloads { |
Collaborator
There was a problem hiding this comment.
instead of the pattern set the env variable and re-read it later could we just modify the project and have that be used as a reference. It would be less error prone reading the code and less performance overhead
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
Adds
--log-payloadstomoose devto enable compact payload logging at ingest and before/after streaming functions (Python/TypeScript), with docs updated.--log-payloadsflag tomoose devinapps/framework-cli/src/cli/commands.rs; when set,apps/framework-cli/src/cli.rssetsMOOSE_LOG_PAYLOADS=true.[PAYLOAD:INGEST]prefix inapps/framework-cli/src/cli/local_webserver.rs.[PAYLOAD:STREAM_IN]before transform and[PAYLOAD:STREAM_OUT]after, gated byMOOSE_LOG_PAYLOADS, inpackages/py-moose-lib/moose_lib/streaming/streaming_function_runner.py.packages/ts-moose-lib/src/streaming-functions/runner.ts; return processed messages viaprocessedMessagesvariable.--log-payloadsusage and log prefixes inapps/framework-docs/src/pages/moose/{moose-cli.mdx,local-dev.mdx}.Written by Cursor Bugbot for commit 32a68fb. This will update automatically on new commits. Configure here.