Fix pytest clean run (Issue #141)#147
Closed
manavgupta26 wants to merge 1 commit into52North:mainfrom
Closed
Conversation
…lision, restore matplotlib rcParams in test_wind_coeff, handle scalar Quantity in calculate_timsestamp, and exclude manual tests by default
Member
|
Closing because this PR is more or less an exact copy of #142. |
Author
|
But the issue 141 is opened with these issue? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR resolves Issue #141 by stabilizing pytest execution on a clean Python 3.11 environment.
Changes:
Updated tests to match current RoutePostprocessing constructor signature (removed outdated positional boat_speed argument).
Improved robustness of calculate_timsestamp() to correctly handle both scalar and vector astropy.units.Quantity inputs for speed.
Restored matplotlib rcParams in test_wind_coeff to prevent global state leakage.
Configured pytest.ini to exclude manual tests by default (-m "not manual"), ensuring clean CI runs.
After these changes, pytest runs successfully on a clean environment without manual tests.
This improves test reliability and aligns the test framework with the intended separation of unit/integration and monitoring tests.