Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes Issue #158
Changes:
Fixed incorrect loop definition in shipParamsPerDist.
Replaced hardcoded file paths in compare.py with dynamic relative paths.
Fixed AttributeError by replacing non-existent .fuel attribute with .fuel_rate
Further Details:
Summary
This PR fixes three issues affecting the execution and portability of the code. The second issue was discovered while addressing the first
Loop Definition Bug
The loop in shipParamsPerDist incorrectly used len() with two arguments, which causes a TypeError in Python.
Fix:
Replaced the incorrect usage with a proper range() iteration so the loop correctly iterates over waypoint indices without runtime errors.
Hardcoded File Paths
compare.py contained file paths that were hardcoded to the original developer’s local machine. This caused a FileNotFoundError when other users ran the script.
Fix:
Replaced these paths with relative paths using os.path, allowing the script to dynamically locate files based on the script’s directory. This makes the code portable and runnable on any system.
AttributeError (.fuel vs .fuel_rate):
The script was attempting to access a non-existent .fuel attribute on the ShipParamsobject. Fix: Corrected to uses the proper .fuel_rate attribute.
Dependencies:
No new dependencies were introduced
PR Checklist:
In the context of this PR, I: