Skip to content

Issue fix#158#159

Open
SARTHAK2427 wants to merge 4 commits into52North:mainfrom
SARTHAK2427:issue-fix#158
Open

Issue fix#158#159
SARTHAK2427 wants to merge 4 commits into52North:mainfrom
SARTHAK2427:issue-fix#158

Conversation

@SARTHAK2427
Copy link

Fixes Issue #158

Changes:

Fixed incorrect loop definition in shipParamsPerDist.

Replaced hardcoded file paths in compare.py with dynamic relative paths.

Fixed AttributeError by replacing non-existent .fuel attribute with .fuel_rate

Further Details:

Summary

This PR fixes three issues affecting the execution and portability of the code. The second issue was discovered while addressing the first

  1. Loop Definition Bug
    The loop in shipParamsPerDist incorrectly used len() with two arguments, which causes a TypeError in Python.
    Fix:
    Replaced the incorrect usage with a proper range() iteration so the loop correctly iterates over waypoint indices without runtime errors.

  2. Hardcoded File Paths
    compare.py contained file paths that were hardcoded to the original developer’s local machine. This caused a FileNotFoundError when other users ran the script.
    Fix:
    Replaced these paths with relative paths using os.path, allowing the script to dynamically locate files based on the script’s directory. This makes the code portable and runnable on any system.

  3. AttributeError (.fuel vs .fuel_rate):
    The script was attempting to access a non-existent .fuel attribute on the ShipParamsobject. Fix: Corrected to uses the proper .fuel_rate attribute.

Dependencies:

No new dependencies were introduced

PR Checklist:

In the context of this PR, I:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant