Release 2019-06-08 12:07:32 +0800

.env.example

@@ -32,7 +32,7 @@ OAUTH_GITHUB_SECRET=acc2d9185cdb236ffc227d4def846f3ade928710
 STAGING_USERNAME=myapp
 STAGING_PASSWORD=myapp
 
-SLACK_WEBHOOK=https://hooks.slack.com/services/xxxxx/xxxx
-DEPLOY_SLACK_WEBHOOK=https://hooks.slack.com/services/xxxxx/xxxx
+SLACK_WEBHOOK=https://hooks.slack.com/services/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
+DEPLOY_SLACK_WEBHOOK=https://hooks.slack.com/services/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
 
 GA_ID=""

.gitignore

@@ -25,7 +25,6 @@
 /public/assets
 /public/uploads
 /.capistrano/*
-/.rubocop_todo.yml
 /.byebug_history
 
 /node_modules

.rubocop.yml

@@ -1,3 +1,9 @@
+inherit_from: .rubocop_todo.yml
+
+require:
+  - rubocop-rails
+  - rubocop-rspec
+
 AllCops:
   Exclude:
     - bin/**/*
@@ -63,16 +69,9 @@ Style/WordArray:
 Metrics/CyclomaticComplexity:
   Enabled: false
 
-Metrics/LineLength:
+Layout/LineLength:
   Enabled: false
 
-Metrics/MethodLength:
-  CountComments: false  # count full line comments?
-  Max: 20
-
-Metrics/AbcSize:
-  Max: 30
-
 Rails/HasAndBelongsToMany:
   Enabled: false
 
@@ -101,7 +100,7 @@ Lint/NestedMethodDefinition:
   Enabled: false
 
 Metrics/AbcSize:
-  Max: 50
+  Max: 300
 
 Metrics/PerceivedComplexity:
   Max: 30
@@ -163,6 +162,6 @@ Rails/UnknownEnv:
 Rails/InverseOf:
   Enabled: false
 
-Naming/UncommunicativeMethodParamName:
+Naming/MethodParameterName:
   Enabled: false
 

.rubocop_todo.yml

@@ -0,0 +1,142 @@
+# This configuration was generated by
+# `rubocop --auto-gen-config`
+# on 2021-10-01 02:08:21 UTC using RuboCop version 1.22.0.
+# The point is for the user to remove these configuration records
+# one by one as the offenses are removed from the code base.
+# Note that changes in the inspected code, or installation of new
+# versions of RuboCop, may require this file to be generated again.
+
+# Offense count: 1
+# Configuration parameters: AllowedMethods.
+# AllowedMethods: enums
+Lint/ConstantDefinitionInBlock:
+  Exclude:
+    - 'spec/loggers/base_logger_spec.rb'
+
+# Offense count: 34
+Lint/MissingSuper:
+  Enabled: false
+
+# Offense count: 1
+# Configuration parameters: IgnoredMethods, CountRepeatedAttributes.
+Metrics/AbcSize:
+  Max: 62
+
+# Offense count: 171
+# Configuration parameters: Prefixes.
+# Prefixes: when, with, without
+RSpec/ContextWording:
+  Enabled: false
+
+# Offense count: 3
+RSpec/EmptyExampleGroup:
+  Exclude:
+    - 'spec/controllers/githubs_controller_spec.rb'
+    - 'spec/controllers/webhooks_controller_spec.rb'
+    - 'spec/models/tag_spec.rb'
+
+# Offense count: 26
+# Configuration parameters: CountAsOne.
+RSpec/ExampleLength:
+  Max: 14
+
+# Offense count: 1
+# Configuration parameters: EnforcedStyle.
+# SupportedStyles: always_allow, single_line_only, disallow
+RSpec/ExampleWithoutDescription:
+  Exclude:
+    - 'spec/services/timecop_spec.rb'
+
+# Offense count: 1
+# Configuration parameters: Include, CustomTransform, IgnoreMethods, SpecSuffixOnly.
+# Include: **/*_spec*rb*, **/spec/**/*
+RSpec/FilePath:
+  Exclude:
+    - 'spec/controllers/users/registrations_controller.spec.rb'
+
+# Offense count: 11
+# Configuration parameters: AssignmentOnly.
+RSpec/InstanceVariable:
+  Exclude:
+    - 'spec/contexts/project_invite_context_spec.rb'
+    - 'spec/contexts/project_remove_user_context_spec.rb'
+    - 'spec/contexts/user_auth_context_spec.rb'
+    - 'spec/contexts/user_create_project_context_spec.rb'
+    - 'spec/controllers/authorizations_controller_spec.rb'
+
+# Offense count: 1
+RSpec/LeakyConstantDeclaration:
+  Exclude:
+    - 'spec/loggers/base_logger_spec.rb'
+
+# Offense count: 14
+RSpec/LetSetup:
+  Exclude:
+    - 'spec/contexts/notify/trigger_context_spec.rb'
+    - 'spec/contexts/project/hours_limit_check_context_spec.rb'
+    - 'spec/contexts/todo_publish_context_spec.rb'
+    - 'spec/controllers/projects_controller_spec.rb'
+    - 'spec/controllers/todos_controller_spec.rb'
+    - 'spec/workers/todos_auto_publish_worker_spec.rb'
+
+# Offense count: 50
+RSpec/MultipleExpectations:
+  Max: 8
+
+# Offense count: 2
+# Configuration parameters: AllowSubject.
+RSpec/MultipleMemoizedHelpers:
+  Max: 9
+
+# Offense count: 227
+# Configuration parameters: IgnoreSharedExamples.
+RSpec/NamedSubject:
+  Enabled: false
+
+# Offense count: 22
+RSpec/NestedGroups:
+  Max: 4
+
+# Offense count: 2
+RSpec/RepeatedExampleGroupDescription:
+  Exclude:
+    - 'spec/controllers/slack_channels_controller_spec.rb'
+
+# Offense count: 52
+RSpec/ScatteredSetup:
+  Exclude:
+    - 'spec/contexts/notify/trigger_context_spec.rb'
+    - 'spec/contexts/todo_calculate_context_spec.rb'
+    - 'spec/contexts/todo_publish_context_spec.rb'
+    - 'spec/controllers/authorizations_controller_spec.rb'
+    - 'spec/controllers/projects_controller_spec.rb'
+    - 'spec/controllers/records_controller_spec.rb'
+    - 'spec/controllers/slack_channels_controller_spec.rb'
+    - 'spec/models/project_spec.rb'
+
+# Offense count: 5
+# Configuration parameters: EnforcedStyle.
+# SupportedStyles: slashes, arguments
+Rails/FilePath:
+  Exclude:
+    - 'app/loggers/github_logger.rb'
+    - 'app/settings/setting.rb'
+    - 'spec/factories/users.rb'
+    - 'spec/loggers/base_logger_spec.rb'
+
+# Offense count: 4
+# Configuration parameters: Include.
+# Include: app/models/**/*.rb
+Rails/UniqueValidationWithoutIndex:
+  Exclude:
+    - 'app/models/authorization.rb'
+    - 'app/models/category.rb'
+    - 'app/models/github.rb'
+    - 'app/models/project_user.rb'
+
+# Offense count: 1
+# Configuration parameters: AllowedMethods.
+# AllowedMethods: respond_to_missing?
+Style/OptionalBooleanParameter:
+  Exclude:
+    - 'app/models/admin/user.rb'

.ruby-version

@@ -1 +1 @@
-2.3.3
+2.6.6

Gemfile

@@ -27,8 +27,9 @@ gem 'slim'
 
 # assets
 gem 'asset_sync'
-gem 'coffee-rails', '~> 4.2'
-gem 'uglifier', '>= 1.3.0'
+gem 'coffee-rails'
+gem 'sassc-rails'
+gem 'uglifier'
 
 # JS plugin
 gem 'jquery-rails'
@@ -37,7 +38,6 @@ gem 'select2-rails', '~> 3'
 # background jobs
 gem 'sidekiq'
 gem 'sidekiq-limit_fetch'
-gem 'sidetiq'
 gem 'sinatra', '~> 2.0.0.beta2'
 
 # file upload
@@ -51,7 +51,7 @@ gem 'paranoia'
 # Use ActiveModel has_secure_password
 # gem 'bcrypt', '~> 3.1.7'
 group :staging, :production do
-  gem 'newrelic_rpm'
+  # gem 'newrelic_rpm'
 end
 
 group :development do
@@ -65,26 +65,31 @@ group :development do
   gem 'slackistrano'
 
   gem 'annotate'
-  gem 'awesome_print'
-  gem 'better_errors'
-  gem 'binding_of_caller'
-  gem 'guard'
-  gem 'guard-annotate'
+  # gem 'awesome_print'
+  # gem 'better_errors'
+  # gem 'binding_of_caller'
+  # gem 'guard'
+  # gem 'guard-annotate'
   gem 'http_logger'
-  gem 'pry'
-  gem 'pry-rails'
-  gem 'pry-remote'
-  gem 'spring'
-  gem 'web-console', '~> 3.0'
-  gem 'xray-rails'
+  # gem 'pry'
+  # gem 'pry-rails'
+  # gem 'pry-remote'
+  # gem 'spring'
+  # gem 'web-console', '~> 3.0'
+  # gem 'xray-rails'
+  gem 'listen'
+  gem 'rails_real_favicon'
+  gem 'rubocop'
+  gem 'rubocop-rails'
+  gem 'rubocop-rspec'
 end
 
 group :development, :test do
   gem 'byebug'
-  gem 'factory_girl_rails'
+  # gem 'factory_girl_rails'
+  gem 'factory_bot_rails'
   gem 'rspec'
   gem 'rspec-rails'
-  gem 'rubocop', require: false
 end
 
 group :test do
@@ -134,7 +139,8 @@ gem 'ransack'
 # omniauth
 gem 'omniauth'
 gem 'omniauth-github'
-
+gem 'omniauth-oauth2'
+gem 'omniauth-rails_csrf_protection'
 # third-party api
 gem 'octokit'