Skip to content

Add trainFDR as a parameter#14

Merged
5h4ng merged 3 commits intomainfrom
train-fdr
Mar 6, 2026
Merged

Add trainFDR as a parameter#14
5h4ng merged 3 commits intomainfrom
train-fdr

Conversation

@5h4ng
Copy link
Copy Markdown
Owner

@5h4ng 5h4ng commented Mar 6, 2026

Add trainFDR as a configurable rescore parameter (default 0.01) that controls the FDR threshold used during model training iterations in mokapot.

@5h4ng
Copy link
Copy Markdown
Owner Author

5h4ng commented Mar 6, 2026

@codex review

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 63b3a13663

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread optimhc/rescore/mokapot.py Outdated
@5h4ng 5h4ng merged commit 4917cfe into main Mar 6, 2026
3 checks passed
5h4ng added a commit that referenced this pull request Mar 6, 2026
5h4ng added a commit that referenced this pull request Mar 6, 2026
Comment thread optimhc/rescore/mokapot.py
@5h4ng 5h4ng deleted the train-fdr branch March 23, 2026 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant