Open
Conversation
- Implemented AuthenticatedHttp utility for GET and POST requests with HBA support. - Created HBA configuration structures and client for managing HBA metadata and token generation. - Updated social interaction methods (friend requests, unfriending, following, blocking) to utilize HBA where applicable. - Added CSRF token handling for secure requests. - Updated vcpkg.json to include OpenSSL dependency.
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request adds Hardware-Backed Authentication (HBA) support and webview login functionality to the AltMan application, along with comprehensive code formatting.
Changes:
- Adds OpenSSL dependency and implements ECDSA P-256 cryptographic signing for Roblox's HBA/BAT system
- Implements webview-based login with cookie extraction for account authentication
- Applies consistent code formatting across the entire codebase
Reviewed changes
Copilot reviewed 60 out of 65 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| vcpkg.json | Adds OpenSSL dependency for cryptographic operations |
| src/utils/ui/webview.hpp | Adds authentication monitoring and cookie extraction to webview |
| src/utils/core/crypto.h | New file implementing ECDSA signing and BAT token generation |
| src/utils/core/base64.h | Fixes base64 encoding/decoding for cryptographic operations |
| src/utils/core/account_utils.h | Adds HBA key generation utilities for accounts |
| src/utils/network/roblox/hba.h | Defines HBA data structures and constants |
| src/utils/network/roblox/hba_client.h | Implements HBA client for metadata fetching and token generation |
| src/utils/network/roblox/authenticated_http.h | Provides authenticated HTTP wrappers with HBA support |
| src/utils/network/roblox/auth.h | Updates authentication methods to support HBA |
| src/utils/network/roblox/social.h | Migrates social API calls to use HBA authentication |
| src/components/data.h | Adds HBA fields to AccountData structure |
| src/main.cpp | Adds HBA migration logic on startup |
| Other files | Code formatting and style consistency improvements |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.