Added render callback argument #15
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The goal is to be able to chain after async `ajax` operation is completed and after template has been applied. - added a third parameter `callback` to `$.fn.render` - checked if `callback` is a function and executed the same in scope of the selection Since we were repeating same work in two places, moved the event trigger code to a single closured function called `applyTemplate`.
…llback argument.
frkr
reviewed
Mar 21, 2017
frkr
left a comment
frkr
left a comment
There was a problem hiding this comment.
in that 'plugin.js' file. Has a trigger event. How can be sure its execute asynchronous?
Author
|
Ah. Its late, but I did some changes to use |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modifies the
$.fn.renderfunction to add a thirdcallbackargument. When a function is passed as the third argument, the function is executed in the rendered element's context upon successful application of the template. This is useful in chaining template loads.The
$.when( /* ... */ ).done()can also be used to arrive to the desired effect, but this is more intuitive for beginners and for rapid prototyping with lesser codes.Lint checked and README updated.